Re: [PATCHES] Fullscreen toolbar button / SMB hide arrows

On Sat, 2003-06-21 at 22:19, Crispin Flowerday wrote:
> Hi,
> 
> Attached are 2 patches to implement the following:
> 
> 1) A fullscreen toolbar button, using the epiphany fullscreen icon which
> is very nice
> 
> 2) A patch to enable the hide_arrows gconf key for smart bookmarks. The
> patch also enabled CTRL+Enter to open the link in a new tab. It also
> fixes middle mouse button when something is in the enrty box. Finally it
> re-enables the clear_entry gconf key.

Great! Thanks.

It would be great if ric could have a look at the patches since it's his
code you're dealing with.  He might also want to have a say about you
using his name in the copyrights :)

The second patch is somewhat hard to follow, you seem to have included
at least five separate things in the same patch.  Would it too much to
ask to have them as separate patches?

You're disabling the arrows when the sbm history is enabled.  Why?  How
are those two related?  (I have a itchy feeling that the history should
actually be always enabled, just have *gasp* an option to hide the
dropdown arrow.)

I'm curious, why would anyone *not* enable the clear_entry pref?  I
mean, all disabling it does is slow you down, as far as I can tell. 
What's the big idea?

ric, do we want that default_width gconf pref?  I feel we should have
either the global pref, or the individual attributes, but not both.  I'd
probably prefer the first, but no strong feelings.  It's just starting
to look like we're starting to accumulate prefs for micromanaging
everything and anything.


Anyway, I think we could use the Ctrl-Enter/middle-click part right away
(could we have that for the location entry as well? *g*) but it's
getting somewhat lost in the noise.  Well, not too badly I suppose. 
I'll just take it out unless ric beats me to it.


Again, thanks.  We could use more active developers around here.  There
are more than the two of you out there, right, RIGHT? ;)

-- 
Tommi Komulainen                                 [email protected]
GPG 1024D/68388EE6    6FD6 DD79 EB38 BF6F 3533  09C0 04A8 9871 6838 8EE6

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA+9XabBKiYcWg4juYRAiwuAKDm75HP8OJCKh3zMel55XveFnIKYQCfWuRD
wnaKUavsZ9jWR4Fgr1o9JI8=
=IMpn
-----END PGP SIGNATURE-----