Re: Re: [PATCHES] Fullscreen toolbar button / SMB hide arrows

> > 1) A fullscreen toolbar button, using the epiphany fullscreen icon which
> > is very nice
> > 
> > 2) A patch to enable the hide_arrows gconf key for smart bookmarks. The
> > patch also enabled CTRL+Enter to open the link in a new tab. It also
> > fixes middle mouse button when something is in the enrty box. Finally it
> > re-enables the clear_entry gconf key.
> 
> Great! Thanks.
> 
> It would be great if ric could have a look at the patches since it's his
> code you're dealing with.  He might also want to have a say about you
> using his name in the copyrights :)

Bit of an oversight the copyright :) Although most of the code is Ric's,
I just copied the galeon-stop-button.{c,h} and turned them into a
fullscreen button.

> The second patch is somewhat hard to follow, you seem to have included
> at least five separate things in the same patch.  Would it too much to
> ask to have them as separate patches?

Not at all, I will split it up this afternoon sometime.

> You're disabling the arrows when the sbm history is enabled.  Why?  How
> are those two related?  (I have a itchy feeling that the history should
> actually be always enabled, just have *gasp* an option to hide the
> dropdown arrow.)

Hmm. I have no idea what happened there, I swear that the code wasn't
like that yesterday :) I will fix that today.

> I'm curious, why would anyone *not* enable the clear_entry pref?  I
> mean, all disabling it does is slow you down, as far as I can tell. 
> What's the big idea?

I was basically just seeing how many of the galeon1 gconf keys I could
get working, although looking at g1 it did some find magic if you
pressed return multiple times with the same entry in the smb. So
thinking about it, probably pointless :)

> ric, do we want that default_width gconf pref?  I feel we should have
> either the global pref, or the individual attributes, but not both.  I'd
> probably prefer the first, but no strong feelings.  It's just starting
> to look like we're starting to accumulate prefs for micromanaging
> everything and anything.

Again, me getting carried away :)

> Anyway, I think we could use the Ctrl-Enter/middle-click part right away
> (could we have that for the location entry as well? *g*) but it's
> getting somewhat lost in the noise.  Well, not too badly I suppose. 
> I'll just take it out unless ric beats me to it.

The Location entry was the next thing on my list of things to get
CTRL+Enter working :)

Crispin




-------------------------------------------------------
This SF.Net email is sponsored by: INetU
Attention Web Developers & Consultants: Become An INetU Hosting Partner.
Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php