Re: Re: [PATCHES] Fullscreen toolbar button / SMB hide arrows

On Wed, 2003-06-25 at 21:59, Ricardo Fernández Pascual wrote:
> > > 
> > > I'm not sure that relying in the order that signals handler get called
> > > is a good idea. Are we sure that gtk+ guarantees that signals connected
> > > later get called earlier always?
> > 
> > In fact GTK does guarantee that signals are called in the order
> > connected, see :
> > 
> > http://developer.gnome.org/doc/API/2.0/gtk/gtk-Signals.html#gtk-signal-connect
> > 
> 
> I thought you were connecting them in the opposite order... 
> 
> Anyway, I don't like it very much (it looks easy to get wrong). I would
> prefer that you added a method to the parent class to connect (or
> better, disconnect) the default signal handler and that the subclass
> called that method if it wanted to override the behavior.

Well.. I already committed that one..  But what if you just used
g_signal_connect_after in the parent class?  That ought to guarantee
correct ordering of signals.


-- 
Tommi Komulainen                                 [email protected]
GPG 1024D/68388EE6    6FD6 DD79 EB38 BF6F 3533  09C0 04A8 9871 6838 8EE6

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA++f/fBKiYcWg4juYRAlgnAJ9rG28T5tklOavV94DPZHTLKKyEIACcCqSx
O70cW7l6E0j7qBzab/xaw7U=
=qsYo
-----END PGP SIGNATURE-----