Re: Some Autocompletion window patches
Tommi Komulainen <[email protected]>
| Newsgroups | gmane.comp.web.galeon.devel |
|---|---|
| Message-ID | <[email protected]> |
On 2003-07-02 22:56 +0100, Crispin Flowerday <[email protected]> wrote: > Hi, > > While attempting to add CTRL+Enter support into the drop-down > autocompletion window, I noticed that it has a rather nasty signal leak, > in that every time the autocompletion window is shown we reattach the > signals for key press and button press, but never disconnect them! Is there some reason the signals couldn't be connected in galeon_autocompletion_window_init_widgets instead, and thus not having to constantly do the connect-disconnect dance? Also, wouldn't it be simpler to use g_signal_handlers_disconnect_matched to disconnect relevant signals, instead of carrying around the signal id's? -- Tommi Komulainen [email protected] GPG 1024D/68388EE6 6FD6 DD79 EB38 BF6F 3533 09C0 04A8 9871 6838 8EE6
signature.asc
(application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (GNU/Linux) iD8DBQE/BI1nBKiYcWg4juYRApTuAKDcpz/cmp/TIzVUXD/boI0fhnTaWwCcCVMI nhC8BRevLhEqa87V3j3e/xQ= =ZFEw -----END PGP SIGNATURE-----