Re: [PATCHES] Better use of download directory.

Le lun 07/07/2003 à 00:35, Crispin Flowerday a écrit :
> Hi,
> 
> Attached is a patch to fix http://bugs.debian.org/197683 . Also attached
> is a patch to make the "save page as" right click menu item ask whether
> to save the images and other stuff.

Both patches look good. I was wondering if it wouldn't be better to save
everything without asking the user.
I'll commit them when I find some time if nobody beats me to it. You
should try to get a gnome cvs account ;)


> 1) The external download program isn't used for that many things, e.g.
> File/Save as doesn't actually use it (and neither does right clicking on
> items on a page and selecting save). Is this behaviour on purpose?

I'd say it's a bug, it was readded a bit late in the galeon2 development
process iirc, philipl probably knows more about that.

The end of your mail probably makes sense, but I'm too tired to really
think about it :)

Christophe

> 
> 2) Also we have 4 gconf variables that determine what directory to
> download to:
> 
>  - /apps/galeon/State/savedir
>  - /apps/galeon/State/saveimagedir (doesn't seem to be used)
>  - /apps/galeon/State/last_download_dir (not in gconf schema)
>  - /apps/galeon/Handlers/Downloading/download_dir
> 
> I was wondering whether it would make more sense to only maintain 2
> gconf variables, the 'download_dir' one for when the user has set the
> 'ask_for_download_dir' to false, and a single state variable for use
> when asking a normal user where to download to?
> 
> Therefore I propose removing the 'savedir' and 'saveimagedir' and
> forcing the internal API (the galeon_embed_utils_save) to always save to
> the 'download_dir' when it isn't asking, and when it is asking to always
> use the 'last_download_dir' key.
> 
> Does that actually make sense :)
> 
> Crispin

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA/C0Ah+13jZzlzSs4RAjhjAJ9CN/p22CUZTVbEdeRKqza6tyYVUwCeN0yn
SOxBpXrz+0thJ7kiEdx3MrQ=
=kg6Y
-----END PGP SIGNATURE-----