Re: Re: Opening tabs from command line (was: Wishlist - bring back the features)

> At the end in which window?
> 
> You are right, the behavior you're seeing is not good.  But you must
> also realize it happens only if you a) open new tab from command line,
> and b) open new tabs in background.
> 
> The default behavior for command line is to open a new window for
> exactly this reason.  Similarly, if jump to new tabs is enabled, there
> shouldn't be a problem finding the tab.  Well, except the common problem
> of finding the window first ;)

Galeon 1 had (IMO) nice behaviour when opening a url from the command
line. If you just said "galeon <url>" and had the open in tabs pref set,
it scanned the open windows, if it found one on your current workspace,
it used that, failing that it opened a new window. (also didn't it jump
to the tab as well?)

I looked at implementing this behaviour, but got stuck at trying to work
out which workspace a window was on. The gnome libraries seem to have
removed the handy functions for working that out :(

The attached patch makes the --new-tab commandline option jump to the
new tab.

-- 
Crispin

http://patches.theflowerdays.com

Index: src/galeon-automation.c
===================================================================
RCS file: /cvs/gnome/galeon/src/galeon-automation.c,v
retrieving revision 1.20
diff -u -r1.20 galeon-automation.c
--- src/galeon-automation.c	8 Jul 2003 16:14:27 -0000	1.20
+++ src/galeon-automation.c	24 Jul 2003 20:24:39 -0000
@@ -126,6 +126,7 @@
 	if (open_in_new_tab)
 	{
 		flags |= GALEON_NEW_TAB_IN_EXISTING_WINDOW;
+		flags |= GALEON_NEW_TAB_JUMP;
 	}
 	
 	galeon_shell_new_tab (galeon_shell, window, NULL, load_page,