Re: Re: Find bookmarks comments
Ricardo Fernández Pascual <[email protected]>
| Newsgroups | gmane.comp.web.galeon.devel |
|---|---|
| Message-ID | <[email protected]> |
El dom, 24-08-2003 a las 21:38, Tommi Komulainen escribió: > On Fri, 2003-08-22 at 18:55, Ricardo Fernández Pascual wrote: > > El jue, 21-08-2003 a las 08:30, Tommi Komulainen escribió: > > > > well, it's not finished, as stated in the Changelog entry. > > And I didn't notice the non-english labels ;) > > And contrary to the ChangeLog, it seems that now you forgot to actually > commit the glade file :) Err, well, I tried to commit it ;) I don't understand what went wrong with cvs this time. Fixed. > > > having a separate dialog for finding bookmarks just feels wrong; now > > > there's two separate windows showing bookmarks and the two don't seem to > > > be connected in any way. > > > > I did the current dialog thinking primarily in the sidebar, where it > > would be most useful. > > > > The don't seem connected because they are not connected actually. Except > > that the find dialog is accessed form the bm editor menu at the momment. > > Hmm.. I suppose I'm missing even bigger picture here then. Where > exactly is this dialog going to be used in? I mean that it is not connected, they are just separate dialogs. The dialog that I did was supposed to be used in the sidebar and when the user selects "Find" from the editor menu. > > > We figured it would be better to have something similar to evolution or > > > rhythmbox (or ephy) where you have the search entry in the same window > > > as the bookmarks. It would make the search much more obvious, IMHO. > > > And yes, I know it's probably more difficult to implement too :-/ > > > > It is not too more difficult to implement. > > But I think it can be confusing. > > > > The treeview in the bookmark editor shows an hierarchy of bookmarks. > > > > The treeview in the find dialog shows a list of bookmarks. Hence, when > > you start searching the meaning of the treeview would change which would > > be confusing, in my opinion. > > > > We could add yet another mode to the bookmark editor to avoid this > > confusion, but I thought that a separate dialog would be cleaner. > > In mozilla the bookmarks editor shows the hierarchy initially, and when > you start the search it just switches to flat search results. I think > that would be quite obvious in at least the single-paned view. What about our two paned view? Probably, the search should be performed recursively starting from the category currently selected in the left pane. > Similarly in epiphany when you start the search, the topic pane > automatically switches to 'All' and also shows the search results in a > flat list (not that there's any hierarchy there at all) in the bookmark > pane. <offtopic> Contrary to what marco wants you to believe, there is an implicit hierarchy there. It's just a little hidden. BTW: I plan to add an UI to make more easy to add a bookmark to several categories, like in Epiphany. That's what aliases are for. </offtopic> We don't have the 'All' category. We could add it, but I don't lie the idea. We could select the root folder, but I don't see why. What that done in Epiphany for some usability reason? or was it just easier for them to implement it that way? > Considering the existing examples, I don't think there'd be much > confusion having the treeview switch from hierarchic to flat list when > showing search results. I will not be confused. When I considered it I thought that it was wrong to change the meaning of the treeview while the user types in another control. Anyway, we will do it that way it you want. > > > Should we include that search on the location entry autocompletion? > > > > how? > > > > FWIW, urls from bookmarks are already used for autocompletion > > Well, I was thinking about having the autocompletion window show the > results in a similar way to the bookmarks find dialog. That is, > emphasize the page titles instead of the URLs. But I don't know if > that's going to work well in practice. I would consider a bug if the autocompletion list did not show the urls clearly, because it's autocompleting an url. The titles of the page (or bookmark) are already shown in the right column, I think that's enough. How could we emphasize them more without hiding the url? > > Consider the current implementation that mockup. That's why I commit it > > before it is really finished. > > Ah, well.. I guess I was just expecting some prior warning, because > it's usually much easier to make even big changes if all you've done so > far is just the mockup. But if commit first, fix later if ever, is the > current practice, nevermind me then... You are trying to start a flame here, aren't you? -- Ricardo Fernández Pascual [email protected] Murcia. España. ------------------------------------------------------- This SF.net email is sponsored by: VM Ware With VMware you can run multiple operating systems on a single machine. WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the same time. Free trial click here:http://www.vmware.com/wl/offer/358/0