Re: Re: Tab width

--OgqxwSJOaUobr8KG
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 04, 2005 at 10:19:24PM +0300, Tommi Komulainen wrote:
>On Tue, 2005-03-29 at 02:32 +0200, Stelian Ionescu wrote:
>> On Mon, Mar 28, 2005 at 01:21:03PM +0300, Tommi Komulainen wrote:
>> >
>> >It would be relatively easy to make the tab width configurable, but as
>> >the defaults work quite nicely there hasn't been too big a need to do
>> >that.  If anyone is interested in hacking Galeon, this would be a nice
>> >task, I'd think.
>> I've attached a patch for this. I've tested it on single/multiple
>> windows and looks ok to me
>
>Thanks, it's good to see some activity for a change :)
>
>Unfortunately some things are badly wrong in that patch and we can't
>accept it as is.  There are two things that go against the existing
>design:
>
>1. Introducing GConf dependency to GulNotebook
>
>I know this isn't clearly documented anywhere, but the basic idea is
>that GulNotebook should have no dependencies outside gtk+  Long time ago
>there was some attempt to get the extra functionality (tab dragging
>etc.) included in GtkNotebook.  Unfortunately these days no one is
>really driving that effort.
>
>
>2. Confused responsibilities in tab width calculation
>
>No one outside GulNotebook should have no part in actually calculating
>the tab width in pixels.  At most one can provide the tab width in
>characters to GulNotebook and let it handle the calculation.
>
>
>
>Basically you just need to move all the calculations behind the
>gul_notebook_set_tab_width() function.  The code in GaleonWindow only
>needs to pass the tab width from GConf to GulNotebook.
thanks for the suggestions. I'll work on it tonight

--=20
Stelian Ionescu aka fe[nl]ix
Quidquid latine dictum sit, altum viditur.

--OgqxwSJOaUobr8KG
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCUZWxKTyIuNqLpocRAnbGAKChbQQXn8kkIYrep9B4n+wdDwWjBACeL5NU
eN1cCUU4ovD0zNh8iBAzUXk=
=byAA
-----END PGP SIGNATURE-----

--OgqxwSJOaUobr8KG--


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click