[gallery/gallery3] cc2aed: #1946, 1947 - Make altered names/slugs more user-f...

  Branch: refs/heads/master
  Home:   https://github.com/gallery/gallery3
  Commit: cc2aed656c7289881ba23e8ec700a4daf7889688
      https://github.com/gallery/gallery3/commit/cc2aed656c7289881ba23e8ec700a4daf7889688
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M installer/install.sql
    M modules/gallery/helpers/gallery_installer.php
    M modules/gallery/helpers/gallery_task.php
    M modules/gallery/helpers/item.php
    M modules/gallery/models/item.php
    M modules/gallery/module.info
    M modules/gallery/tests/Item_Model_Test.php

  Log Message:
  -----------
  #1946, 1947 - Make altered names/slugs more user-friendly, make conflict-finding code check filenames with no extensions
- Reduced from four places that alter names/slugs to two (one to populate empty slugs, one to handle conflicting names/slugs).
- For empty slugs, fill with generic human-readable name (e.g. "photo") instead of random value.
- For conflicting names/slugs, add suffix that's sequential (e.g. "-01"), only using random after 99 conflicts.
- Made conflict-finding code check filenames with no extensions.
- Renamed _randomize_name_or_slug_on_conflict to _check_and_fix_conflicts.
- Added unit tests.  Also cleaned up existing unit tests to reflect new logic and removed a redundant test.
- Added installer logic to correct existing items now considered in conflict.
- Revised gallery_task to look for duplicate names based on new criteria.


  Commit: 6042bfd1f519ee543483f9850b04621f58a7ff19
      https://github.com/gallery/gallery3/commit/6042bfd1f519ee543483f9850b04621f58a7ff19
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M installer/install.sql
    M modules/gallery/helpers/gallery_installer.php
    M modules/gallery/helpers/gallery_task.php
    M modules/gallery/helpers/item.php
    M modules/gallery/models/item.php
    M modules/gallery/module.info
    M modules/gallery/tests/Item_Model_Test.php

  Log Message:
  -----------
  Merge pull request #91 from shadlaws/fix_1946_1947

#1946, 1947 - Make altered names/slugs more user-friendly, make conflict-finding code check filenames with no extensions


Compare: https://github.com/gallery/gallery3/compare/847a825b2527...6042bfd1f519

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]