[gallery/gallery3] 536bda: #1967 - Improve how graphics::generate handles mis...

  Branch: refs/heads/master
  Home:   https://github.com/gallery/gallery3
  Commit: 536bdaa4db6e950cb4f382697964651b8eab63cd
      https://github.com/gallery/gallery3/commit/536bdaa4db6e950cb4f382697964651b8eab63cd
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-01-29 (Tue, 29 Jan 2013)

  Changed paths:
    M modules/gallery/helpers/graphics.php
    A modules/gallery/images/missing_photo.jpg
    R modules/gallery/images/missing_photo.png
    A modules/gallery/tests/Graphics_Helper_Test.php

  Log Message:
  -----------
  #1967 - Improve how graphics::generate handles missing/bad images.
- Made missing_photo match the image format (jpg, png, etc.).
- Swapped missing_photo.png for missing_photo.jpg since it's likely to require less conversion to match.
- Improved error messages to user when things go wrong.
- Ensured that missing image placeholders are always copied when there's an error.
- Ensured we don't mistake no file output for a correct file output (delete target before attempt).
- Restructured graphics::generate a bit to work better with above changes.
- Added unit tests for graphics::generate.


  Commit: a3478732f910eb7eff93dfa5cc44d833b995d79a
      https://github.com/gallery/gallery3/commit/a3478732f910eb7eff93dfa5cc44d833b995d79a
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-29 (Tue, 29 Jan 2013)

  Changed paths:
    M modules/gallery/helpers/graphics.php
    A modules/gallery/images/missing_photo.jpg
    R modules/gallery/images/missing_photo.png
    A modules/gallery/tests/Graphics_Helper_Test.php

  Log Message:
  -----------
  Merge pull request #105 from shadlaws/fix_1967

#1967 - Improve how graphics::generate handles missing/bad images.


Compare: https://github.com/gallery/gallery3/compare/b7c73ee69347...a3478732f910

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]