[gallery/gallery3] cf0774: #1968 - Improve album cover generation/removal/etc...

GitHub <noreply-9UaJU3cA/F/[email protected]>
Newsgroups gmane.comp.web.gallery.cvs
Message-ID <[email protected]> 
  Branch: refs/heads/3.0.x
  Home:   https://github.com/gallery/gallery3
  Commit: cf077425953a6a492dea97eaf1517e7d08c9648f
      https://github.com/gallery/gallery3/commit/cf077425953a6a492dea97eaf1517e7d08c9648f
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-01-29 (Tue, 29 Jan 2013)

  Changed paths:
    M modules/gallery/helpers/gallery_event.php
    M modules/gallery/helpers/graphics.php
    M modules/gallery/helpers/item.php
    M modules/gallery/models/item.php
    M modules/gallery/tests/Graphics_Helper_Test.php

  Log Message:
  -----------
  #1968 - Improve album cover generation/removal/etc.
- Added stanza to Item_Model::save that handles when cover id is null.
- Added logic to graphics::generate to copy/convert album cover thumbs from their item thumbs to ensure they're always jpg, and eliminate the possibility that we copy/convert a dirty thumb.
- Redirected other places in code where we want to do one of the above two things to use these two functions instead (gallery_event::item_updated_data_file, item::make_album_cover, item::remove_album_cover).
- Improved validation in Item_Model so only albums can have covers and all covers must be non-albums.
- Added unit tests to Graphics_Helper_Test.


  Commit: 92c264033a23cd9e7473a60948760baefd488407
      https://github.com/gallery/gallery3/commit/92c264033a23cd9e7473a60948760baefd488407
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M modules/gallery/js/l10n_client.js

  Log Message:
  -----------
  Don't concatenate tainted strings in JS.  Fixes #1976.


  Commit: 8ada16d887e0ad6fc68750c325c9d8594cbe1025
      https://github.com/gallery/gallery3/commit/8ada16d887e0ad6fc68750c325c9d8594cbe1025
  Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater-gXXrQ4p6DQJBDgjK7y7TUQ@public.gmane.org>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M .build_number

  Log Message:
  -----------
  Automated update of .build_number to 309 for branch master
Last update: 28cd0ad2c13fec256c4a0f162ec7b552eb88d66c (1 commits ago)


  Commit: 9ef891858ca6ccf4213c5981868c6175cb2cde47
      https://github.com/gallery/gallery3/commit/9ef891858ca6ccf4213c5981868c6175cb2cde47
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M modules/watermark/controllers/admin_watermarks.php

  Log Message:
  -----------
  Protect admins from themselves - in case an admin changed the
watermark.name setting to something terrible by accident via Admin >
Advanced, we'll just use the basename.  Fixes #1977.


  Commit: ee0a0d7bf7ef6ae05a8961f8a956871a8c7bf371
      https://github.com/gallery/gallery3/commit/ee0a0d7bf7ef6ae05a8961f8a956871a8c7bf371
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M .build_number

  Log Message:
  -----------
  Merge branch 'master' of github.com:gallery/gallery3


  Commit: 8de70ee7bc02d99261705e391b7187e84dc3f896
      https://github.com/gallery/gallery3/commit/8de70ee7bc02d99261705e391b7187e84dc3f896
  Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater-gXXrQ4p6DQJBDgjK7y7TUQ@public.gmane.org>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M .build_number

  Log Message:
  -----------
  Automated update of .build_number to 310 for branch master
Last update: 28cd0ad2c13fec256c4a0f162ec7b552eb88d66c (3 commits ago)


  Commit: 49dd0994df6f6709dcd9ea6971beb13c68a99cf0
      https://github.com/gallery/gallery3/commit/49dd0994df6f6709dcd9ea6971beb13c68a99cf0
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M modules/gallery/libraries/Theme_View.php

  Log Message:
  -----------
  Follow-on to 1e4d75c12072b49c3469f18af13bcf3439afc6b0 for #1975.
Create a siblings() function which pulls together the siblings_callback
function and makes it a more palatable API.


  Commit: b6b269948f10a727384723b5c8a4630273242bce
      https://github.com/gallery/gallery3/commit/b6b269948f10a727384723b5c8a4630273242bce
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M .build_number

  Log Message:
  -----------
  Merge branch 'master' of github.com:gallery/gallery3


  Commit: 0ab40de11d65476454d4bf1129916a6856001002
      https://github.com/gallery/gallery3/commit/0ab40de11d65476454d4bf1129916a6856001002
  Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater-gXXrQ4p6DQJBDgjK7y7TUQ@public.gmane.org>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M .build_number

  Log Message:
  -----------
  Automated update of .build_number to 311 for branch master
Last update: 28cd0ad2c13fec256c4a0f162ec7b552eb88d66c (5 commits ago)


  Commit: d8d01e0aa0cac2b8576ae481527d875213cdc3a7
      https://github.com/gallery/gallery3/commit/d8d01e0aa0cac2b8576ae481527d875213cdc3a7
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M modules/gallery/helpers/gallery_event.php
    M modules/gallery/helpers/graphics.php
    M modules/gallery/helpers/item.php
    M modules/gallery/models/item.php
    M modules/gallery/tests/Graphics_Helper_Test.php

  Log Message:
  -----------
  Merge pull request #112 from shadlaws/fix_1968

#1968 - Improve album cover generation/removal/etc.


  Commit: 12ea6ad642c0e84fe67f1324f8fa00c9534e7aa5
      https://github.com/gallery/gallery3/commit/12ea6ad642c0e84fe67f1324f8fa00c9534e7aa5
  Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater-gXXrQ4p6DQJBDgjK7y7TUQ@public.gmane.org>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M .build_number

  Log Message:
  -----------
  Automated update of .build_number to 312 for branch master
Last update: 0ab40de11d65476454d4bf1129916a6856001002 (1 commits ago)


  Commit: cff1e76e8da2055f9faf7449222b43a686014b1c
      https://github.com/gallery/gallery3/commit/cff1e76e8da2055f9faf7449222b43a686014b1c
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M modules/gallery/helpers/item.php

  Log Message:
  -----------
  When changing the album cover, find and retarget any other albums which were using the old item as their album cover.  Fixes #1978.


  Commit: ec232f6a47a7ee64acd1641775bbdb2f8b351134
      https://github.com/gallery/gallery3/commit/ec232f6a47a7ee64acd1641775bbdb2f8b351134
  Author: Automatic Build Number Updater <bharat+gallery3_build_number_updater-gXXrQ4p6DQJBDgjK7y7TUQ@public.gmane.org>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M .build_number

  Log Message:
  -----------
  Automated update of .build_number to 313 for branch master
Last update: 12ea6ad642c0e84fe67f1324f8fa00c9534e7aa5 (1 commits ago)


  Commit: 075b95f0ed6f843c64756c772011a1ecb406168f
      https://github.com/gallery/gallery3/commit/075b95f0ed6f843c64756c772011a1ecb406168f
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M modules/gallery/helpers/gallery_event.php

  Log Message:
  -----------
  Actually disable the "make album cover" option when the item is already the album cover.  Fixes #1979.


  Commit: 30ec44b3b2cdf20e842ba1fe9645ed9fbf0c1f18
      https://github.com/gallery/gallery3/commit/30ec44b3b2cdf20e842ba1fe9645ed9fbf0c1f18
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M .build_number

  Log Message:
  -----------
  Merge branch 'master' of github.com:gallery/gallery3


  Commit: 3855955a5a9d9620974b9e552ffae72781e33459
      https://github.com/gallery/gallery3/commit/3855955a5a9d9620974b9e552ffae72781e33459
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-01-30 (Wed, 30 Jan 2013)

  Changed paths:
    M modules/gallery/helpers/gallery_event.php
    M modules/gallery/helpers/graphics.php
    M modules/gallery/helpers/item.php
    M modules/gallery/js/l10n_client.js
    M modules/gallery/libraries/Theme_View.php
    M modules/gallery/models/item.php
    M modules/gallery/tests/Graphics_Helper_Test.php
    M modules/watermark/controllers/admin_watermarks.php

  Log Message:
  -----------
  Merge branch 'master' into 3.0.x


Compare: https://github.com/gallery/gallery3/compare/64f254ef6213...3855955a5a9d

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.