[gallery/gallery3] 04a011: Add missing public/private function definition to ...

GitHub <noreply-9UaJU3cA/F/[email protected]>
Newsgroups gmane.comp.web.gallery.cvs
Message-ID <515e9fb4a7f30_1a3ecef130728fd@hookshot-fe6-pe1-prd.aws.github.net.mail> 
  Branch: refs/heads/kohana_3
  Home:   https://github.com/gallery/gallery3
  Commit: 04a011abfd53d8ccb7a6287342dac75870e170aa
      https://github.com/gallery/gallery3/commit/04a011abfd53d8ccb7a6287342dac75870e170aa
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Admin/ThemeOptions.php
    M modules/gallery/classes/Gallery/Controller/Admin/UpgradeChecker.php
    M modules/gallery/classes/Gallery/Controller/Albums.php
    M modules/gallery/classes/Gallery/Controller/Packager.php
    M modules/gallery/classes/Gallery/Controller/Permissions.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
    M modules/notification/classes/Notification/Controller/Notification.php
    M modules/organize/classes/Organize/Controller/Organize.php
    M modules/search/classes/Search/Controller/Search.php
    M modules/server_add/classes/ServerAdd/Controller/ServerAdd.php
    M modules/tag/classes/Tag/Controller/Tag.php
    M modules/user/classes/User/Controller/Admin/Users.php

  Log Message:
  -----------
  Add missing public/private function definition to Controller functions.


  Commit: 78f68291e394c6640a035c4aaac20cd87dbd1bea
      https://github.com/gallery/gallery3/commit/78f68291e394c6640a035c4aaac20cd87dbd1bea
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M modules/akismet/classes/Akismet/Controller/Admin/Akismet.php
    M modules/comment/classes/Comment/Controller/Admin/Comments.php
    M modules/comment/classes/Comment/Controller/Admin/ManageComments.php
    M modules/comment/classes/Comment/Controller/Comments.php
    M modules/exif/classes/Exif/Controller/Exif.php
    M modules/g2_import/classes/G2Import/Controller/Admin/G2Import.php
    M modules/g2_import/classes/G2Import/Controller/G2.php
    M modules/gallery/classes/Gallery/Controller/Admin/AdvancedSettings.php
    M modules/gallery/classes/Gallery/Controller/Admin/Dashboard.php
    M modules/gallery/classes/Gallery/Controller/Admin/Graphics.php
    M modules/gallery/classes/Gallery/Controller/Admin/Languages.php
    M modules/gallery/classes/Gallery/Controller/Admin/Maintenance.php
    M modules/gallery/classes/Gallery/Controller/Admin/Modules.php
    M modules/gallery/classes/Gallery/Controller/Admin/Movies.php
    M modules/gallery/classes/Gallery/Controller/Admin/Sidebar.php
    M modules/gallery/classes/Gallery/Controller/Admin/ThemeOptions.php
    M modules/gallery/classes/Gallery/Controller/Admin/Themes.php
    M modules/gallery/classes/Gallery/Controller/Admin/UpgradeChecker.php
    M modules/gallery/classes/Gallery/Controller/Albums.php
    M modules/gallery/classes/Gallery/Controller/Combined.php
    M modules/gallery/classes/Gallery/Controller/Items.php
    M modules/gallery/classes/Gallery/Controller/L10nClient.php
    M modules/gallery/classes/Gallery/Controller/Login.php
    M modules/gallery/classes/Gallery/Controller/Logout.php
    M modules/gallery/classes/Gallery/Controller/Movies.php
    M modules/gallery/classes/Gallery/Controller/Packager.php
    M modules/gallery/classes/Gallery/Controller/Permissions.php
    M modules/gallery/classes/Gallery/Controller/Photos.php
    M modules/gallery/classes/Gallery/Controller/Quick.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
    M modules/gallery/classes/Gallery/Controller/Upgrader.php
    M modules/gallery/classes/Gallery/Controller/Uploader.php
    M modules/gallery/classes/Gallery/Controller/UserProfile.php
    M modules/gallery/classes/Gallery/Controller/WelcomeMessage.php
    M modules/image_block/classes/ImageBlock/Controller/ImageBlock.php
    M modules/notification/classes/Notification/Controller/Notification.php
    M modules/organize/classes/Organize/Controller/Organize.php
    M modules/recaptcha/classes/Recaptcha/Controller/Admin/Recaptcha.php
    M modules/rest/classes/Rest/Controller/Rest.php
    M modules/rss/classes/Rss/Controller/Rss.php
    M modules/search/classes/Search/Controller/Search.php
    M modules/server_add/classes/ServerAdd/Controller/Admin/ServerAdd.php
    M modules/server_add/classes/ServerAdd/Controller/ServerAdd.php
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    M modules/tag/classes/Tag/Controller/Tag.php
    M modules/tag/classes/Tag/Controller/Tags.php
    M modules/user/classes/User/Controller/Admin/Users.php
    M modules/user/classes/User/Controller/Password.php
    M modules/user/classes/User/Controller/Users.php
    M modules/watermark/classes/Watermark/Controller/Admin/Watermarks.php

  Log Message:
  -----------
  Add "action_" to *every* public Controller function (171 places).  This is probably too much, so we'll undo a few next.


  Commit: dd621d23386634bb5284a477f050832fa8c0e433
      https://github.com/gallery/gallery3/commit/dd621d23386634bb5284a477f050832fa8c0e433
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Admin/Languages.php
    M modules/gallery/classes/Gallery/Controller/Admin/ThemeOptions.php
    M modules/gallery/classes/Gallery/Controller/Albums.php
    M modules/gallery/classes/Gallery/Controller/L10nClient.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
    M modules/gallery/tests/Albums_Controller_Test.php
    M modules/gallery/tests/Photos_Controller_Test.php
    M modules/search/classes/Search/Controller/Search.php
    M modules/server_add/classes/ServerAdd/Controller/ServerAdd.php
    M modules/tag/classes/Tag/Controller/Tag.php
    M modules/watermark/tests/Admin_Watermarks_Controller_Test.php

  Log Message:
  -----------
  Manually fix issues arising from adding "action_" to public Controller functions.
- remove "action_" from all get_siblings() and get_display_context() callbacks
- remove "action_" from Controller_ServerAdd::add() callback
- remove "action_" from Controller_Reauthenticate::valid_password() callback
- remove "action_" from Controller_L10nClient::l10_form() callback
- remove "action__" from Controller_ThemeOptions::validate_page_size() callback
- change $this->index to $this->action_index in Controller_Languages
- change $controller->add to $controller->action_add in unit test classes
- change $controller->update to $controller->action_update in unit test classes


  Commit: 80447de4a348c240d2e65ce29f2b3d03b9eb2d49
      https://github.com/gallery/gallery3/commit/80447de4a348c240d2e65ce29f2b3d03b9eb2d49
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-05 (Fri, 05 Apr 2013)

  Changed paths:
    M modules/akismet/classes/Akismet/Controller/Admin/Akismet.php
    M modules/comment/classes/Comment/Controller/Admin/Comments.php
    M modules/comment/classes/Comment/Controller/Admin/ManageComments.php
    M modules/comment/classes/Comment/Controller/Comments.php
    M modules/exif/classes/Exif/Controller/Exif.php
    M modules/g2_import/classes/G2Import/Controller/Admin/G2Import.php
    M modules/g2_import/classes/G2Import/Controller/G2.php
    M modules/gallery/classes/Gallery/Controller/Admin/AdvancedSettings.php
    M modules/gallery/classes/Gallery/Controller/Admin/Dashboard.php
    M modules/gallery/classes/Gallery/Controller/Admin/Graphics.php
    M modules/gallery/classes/Gallery/Controller/Admin/Languages.php
    M modules/gallery/classes/Gallery/Controller/Admin/Maintenance.php
    M modules/gallery/classes/Gallery/Controller/Admin/Modules.php
    M modules/gallery/classes/Gallery/Controller/Admin/Movies.php
    M modules/gallery/classes/Gallery/Controller/Admin/Sidebar.php
    M modules/gallery/classes/Gallery/Controller/Admin/ThemeOptions.php
    M modules/gallery/classes/Gallery/Controller/Admin/Themes.php
    M modules/gallery/classes/Gallery/Controller/Admin/UpgradeChecker.php
    M modules/gallery/classes/Gallery/Controller/Albums.php
    M modules/gallery/classes/Gallery/Controller/Combined.php
    M modules/gallery/classes/Gallery/Controller/Items.php
    M modules/gallery/classes/Gallery/Controller/L10nClient.php
    M modules/gallery/classes/Gallery/Controller/Login.php
    M modules/gallery/classes/Gallery/Controller/Logout.php
    M modules/gallery/classes/Gallery/Controller/Movies.php
    M modules/gallery/classes/Gallery/Controller/Packager.php
    M modules/gallery/classes/Gallery/Controller/Permissions.php
    M modules/gallery/classes/Gallery/Controller/Photos.php
    M modules/gallery/classes/Gallery/Controller/Quick.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
    M modules/gallery/classes/Gallery/Controller/Upgrader.php
    M modules/gallery/classes/Gallery/Controller/Uploader.php
    M modules/gallery/classes/Gallery/Controller/UserProfile.php
    M modules/gallery/classes/Gallery/Controller/WelcomeMessage.php
    M modules/gallery/tests/Albums_Controller_Test.php
    M modules/gallery/tests/Photos_Controller_Test.php
    M modules/image_block/classes/ImageBlock/Controller/ImageBlock.php
    M modules/notification/classes/Notification/Controller/Notification.php
    M modules/organize/classes/Organize/Controller/Organize.php
    M modules/recaptcha/classes/Recaptcha/Controller/Admin/Recaptcha.php
    M modules/rest/classes/Rest/Controller/Rest.php
    M modules/rss/classes/Rss/Controller/Rss.php
    M modules/search/classes/Search/Controller/Search.php
    M modules/server_add/classes/ServerAdd/Controller/Admin/ServerAdd.php
    M modules/server_add/classes/ServerAdd/Controller/ServerAdd.php
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    M modules/tag/classes/Tag/Controller/Tag.php
    M modules/tag/classes/Tag/Controller/Tags.php
    M modules/user/classes/User/Controller/Admin/Users.php
    M modules/user/classes/User/Controller/Password.php
    M modules/user/classes/User/Controller/Users.php
    M modules/watermark/classes/Watermark/Controller/Admin/Watermarks.php
    M modules/watermark/tests/Admin_Watermarks_Controller_Test.php

  Log Message:
  -----------
  Merge pull request #272 from shadlaws/controller_function_names

Controller function names


Compare: https://github.com/gallery/gallery3/compare/8b232f4a2c59...80447de4a348

------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire 
the most talented Cisco Certified professionals. Visit the 
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.