[gallery/gallery3] c5c2d9: Revise 60 actions that take 1 id-like argument to ...

GitHub <noreply-9UaJU3cA/F/[email protected]> Thu, 18 Apr 2013 03:37:43 -0700
Newsgroups gmane.comp.web.gallery.cvs
Message-ID <516fccf7d1276_282bd83e2077695@hookshot-fe3-pe1-prd.aws.github.net.mail>
  Branch: refs/heads/kohana_3
  Home:   https://github.com/gallery/gallery3
  Commit: c5c2d9b342144e6a95b7224671a3b7b7a015193a
      https://github.com/gallery/gallery3/commit/c5c2d9b342144e6a95b7224671a3b7b7a015193a
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M modules/comment/classes/Comment/Controller/Comments.php
    M modules/exif/classes/Exif/Controller/Exif.php
    M modules/gallery/classes/Gallery/Controller/Admin/Dashboard.php
    M modules/gallery/classes/Gallery/Controller/Admin/Graphics.php
    M modules/gallery/classes/Gallery/Controller/Admin/Maintenance.php
    M modules/gallery/classes/Gallery/Controller/Albums.php
    M modules/gallery/classes/Gallery/Controller/Items.php
    M modules/gallery/classes/Gallery/Controller/Movies.php
    M modules/gallery/classes/Gallery/Controller/Permissions.php
    M modules/gallery/classes/Gallery/Controller/Photos.php
    M modules/gallery/classes/Gallery/Controller/Quick.php
    M modules/gallery/classes/Gallery/Controller/Uploader.php
    M modules/gallery/classes/Gallery/Controller/UserProfile.php
    M modules/image_block/classes/ImageBlock/Controller/ImageBlock.php
    M modules/notification/classes/Notification/Controller/Notification.php
    M modules/organize/classes/Organize/Controller/Organize.php
    M modules/server_add/classes/ServerAdd/Controller/ServerAdd.php
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    M modules/tag/classes/Tag/Controller/Tags.php
    M modules/user/classes/User/Controller/Admin/Users.php
    M modules/user/classes/User/Controller/Users.php

  Log Message:
  -----------
  Revise 60 actions that take 1 id-like argument to use arg_required(0, "digit").


  Commit: ab08449fb57064d431c0c6f39f493444df4c91df
      https://github.com/gallery/gallery3/commit/ab08449fb57064d431c0c6f39f493444df4c91df
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M modules/comment/classes/Comment/Controller/Admin/ManageComments.php
    M modules/gallery/classes/Gallery/Controller/Admin/Maintenance.php
    M modules/gallery/classes/Gallery/Controller/Admin/UpgradeChecker.php
    M modules/gallery/classes/Gallery/Controller/Combined.php

  Log Message:
  -----------
  Revise 6 actions that take 1 argument to use arg_required() with various rules.
- 1 alpha, 2 alpha_dash, 2 digit, and 1 without a rule (a callback).


  Commit: 267bf6b7166b79da4d56932f293ae50d684e2f07
      https://github.com/gallery/gallery3/commit/267bf6b7166b79da4d56932f293ae50d684e2f07
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M modules/comment/classes/Comment/Controller/Admin/ManageComments.php
    M modules/gallery/classes/Gallery/Controller/Admin/AdvancedSettings.php
    M modules/gallery/classes/Gallery/Controller/Admin/Themes.php
    M modules/gallery/classes/Gallery/Controller/Permissions.php
    M modules/gallery/classes/Gallery/Controller/Quick.php
    M modules/gallery/classes/Gallery/Controller/Uploader.php
    M modules/rss/classes/Rss/Controller/Rss.php
    M modules/user/classes/User/Controller/Admin/Users.php

  Log Message:
  -----------
  Revise 11 actions that take 2-4 arguments to use arg_required() (or, in 1 case, arg()).


  Commit: 0973750c1d2ad565428257274be6875f3f1f6cfe
      https://github.com/gallery/gallery3/commit/0973750c1d2ad565428257274be6875f3f1f6cfe
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Admin/Languages.php

  Log Message:
  -----------
  Revise Admin_Languages controller structure.
- pull show_languages_view() out of action_index() to make it a clearer action.
- make private _share_translations_form() into public get_share_translations_form().


  Commit: 8988b4766dab2e2dddff8fd8aa6fb07eac89207f
      https://github.com/gallery/gallery3/commit/8988b4766dab2e2dddff8fd8aa6fb07eac89207f
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Combined.php

  Log Message:
  -----------
  Fix Combined so it doesn't crash if HTTP_IF_MODIFIED_SINCE isn't set.


  Commit: ff2e1dd58c60ca90e3025dcff29319ef809e4802
      https://github.com/gallery/gallery3/commit/ff2e1dd58c60ca90e3025dcff29319ef809e4802
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Cache/Database.php
    M modules/gallery/classes/Gallery/Hook/GalleryTask.php
    M modules/gallery/classes/Gallery/I18n.php
    M modules/gallery/classes/Gallery/Item.php
    M modules/gallery/classes/Gallery/Model/Task.php
    M modules/gallery/classes/Gallery/UpgradeChecker.php
    M modules/gallery/classes/Gallery/View/Gallery.php

  Log Message:
  -----------
  Fix Cache_Database get() and set(), revise set() calls to use K3 syntax (7 places).
- change get() to use ORM for simplicity.
- change get() to return $default if nothing found.
- change set() to pass tags to set_with_tags().
- update set() calls to reverse lifetime and tags arguments (7 places).
- note: no changes to set_with_tags().


  Commit: 589e3d5d060d62500142e56f3469d5c77ac77716
      https://github.com/gallery/gallery3/commit/589e3d5d060d62500142e56f3469d5c77ac77716
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Combined.php
    M modules/gallery/classes/Gallery/Controller/FileProxy.php
    M modules/gallery/classes/Gallery/Hook/Rest/Data.php

  Log Message:
  -----------
  Update Combined, FileProxy, and Rest_Data to send files the K3 way.
- use check_cache() to set etags, check etags, and send 304 if not changed.
- use request->headers() and response->headers() to work with headers.
- use response->send_file() to send files.
- use response->body() and response->send_file() to send generated content.
- remove all hand-coded header and buffer calls (K3 does this for us).


  Commit: 5a7ec9d5fc1f1a85254afec1d74761de20f51c4d
      https://github.com/gallery/gallery3/commit/5a7ec9d5fc1f1a85254afec1d74761de20f51c4d
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-18 (Thu, 18 Apr 2013)

  Changed paths:
    M modules/comment/classes/Comment/Controller/Admin/ManageComments.php
    M modules/comment/classes/Comment/Controller/Comments.php
    M modules/exif/classes/Exif/Controller/Exif.php
    M modules/gallery/classes/Gallery/Cache/Database.php
    M modules/gallery/classes/Gallery/Controller/Admin/AdvancedSettings.php
    M modules/gallery/classes/Gallery/Controller/Admin/Dashboard.php
    M modules/gallery/classes/Gallery/Controller/Admin/Graphics.php
    M modules/gallery/classes/Gallery/Controller/Admin/Languages.php
    M modules/gallery/classes/Gallery/Controller/Admin/Maintenance.php
    M modules/gallery/classes/Gallery/Controller/Admin/Themes.php
    M modules/gallery/classes/Gallery/Controller/Admin/UpgradeChecker.php
    M modules/gallery/classes/Gallery/Controller/Albums.php
    M modules/gallery/classes/Gallery/Controller/Combined.php
    M modules/gallery/classes/Gallery/Controller/FileProxy.php
    M modules/gallery/classes/Gallery/Controller/Items.php
    M modules/gallery/classes/Gallery/Controller/Movies.php
    M modules/gallery/classes/Gallery/Controller/Permissions.php
    M modules/gallery/classes/Gallery/Controller/Photos.php
    M modules/gallery/classes/Gallery/Controller/Quick.php
    M modules/gallery/classes/Gallery/Controller/Uploader.php
    M modules/gallery/classes/Gallery/Controller/UserProfile.php
    M modules/gallery/classes/Gallery/Hook/GalleryTask.php
    M modules/gallery/classes/Gallery/Hook/Rest/Data.php
    M modules/gallery/classes/Gallery/I18n.php
    M modules/gallery/classes/Gallery/Item.php
    M modules/gallery/classes/Gallery/Model/Task.php
    M modules/gallery/classes/Gallery/UpgradeChecker.php
    M modules/gallery/classes/Gallery/View/Gallery.php
    M modules/image_block/classes/ImageBlock/Controller/ImageBlock.php
    M modules/notification/classes/Notification/Controller/Notification.php
    M modules/organize/classes/Organize/Controller/Organize.php
    M modules/rss/classes/Rss/Controller/Rss.php
    M modules/server_add/classes/ServerAdd/Controller/ServerAdd.php
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    M modules/tag/classes/Tag/Controller/Tags.php
    M modules/user/classes/User/Controller/Admin/Users.php
    M modules/user/classes/User/Controller/Users.php

  Log Message:
  -----------
  Merge pull request #299 from shadlaws/args_cache_sendfile

Args, cache, send_file


Compare: https://github.com/gallery/gallery3/compare/5e05bf410f46...5a7ec9d5fc1f

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]