[gallery/gallery3] c13284: Change flow so that we assert after the line that ...

  Branch: refs/heads/kohana_3
  Home:   https://github.com/gallery/gallery3
  Commit: c13284b9d3470a967e64325e8624a290ca2c713c
      https://github.com/gallery/gallery3/commit/c13284b9d3470a967e64325e8624a290ca2c713c
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-04-28 (Sun, 28 Apr 2013)

  Changed paths:
    M modules/gallery/tests/Item_Rest_Helper_Test.php

  Log Message:
  -----------
  Change flow so that we assert after the line that should fail.  Avoid returns.


  Commit: 558cb725d83a4cbbe622838b7d17b05a9c5f9718
      https://github.com/gallery/gallery3/commit/558cb725d83a4cbbe622838b7d17b05a9c5f9718
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-04-29 (Mon, 29 Apr 2013)

  Changed paths:
    M modules/g2_import/classes/G2Import/G2Import.php
    M modules/gallery/classes/Gallery/Access.php
    M modules/gallery/classes/Gallery/Breadcrumb.php
    M modules/gallery/classes/Gallery/Controller/Albums.php
    M modules/gallery/classes/Gallery/Controller/Permissions.php
    M modules/gallery/classes/Gallery/Controller/Quick.php
    M modules/gallery/classes/Gallery/Controller/Uploader.php
    M modules/gallery/classes/Gallery/Hook/GalleryEvent.php
    M modules/gallery/classes/Gallery/Hook/GalleryRss.php
    M modules/gallery/classes/Gallery/Hook/Rest/Items.php
    M modules/gallery/classes/Gallery/Hook/Rest/Tree.php
    M modules/gallery/classes/Gallery/Item.php
    M modules/gallery/classes/Gallery/Model/Item.php
    M modules/gallery/classes/Gallery/ORM.php
    M modules/gallery/classes/Gallery/ORM/MPTT.php
    M modules/gallery/classes/Gallery/View/Theme.php
    M modules/gallery/orphans/views/form_uploadify.html.php
    M modules/gallery/tests/Items_Rest_Helper_Test.php
    M modules/gallery/tests/ORM_MPTT_Test.php
    M modules/notification/classes/Notification/Notification.php
    M modules/notification/views/notification/item_deleted.html.php
    M modules/organize/classes/Organize/Controller/Organize.php
    M modules/organize/classes/Organize/Hook/OrganizeEvent.php
    M modules/rss/classes/Rss/Hook/RssTheme.php
    M modules/server_add/classes/ServerAdd/Hook/ServerAddEvent.php
    M modules/server_add/views/server_add/tree_dialog.html.php
    M modules/slideshow/classes/Slideshow/Hook/SlideshowEvent.php

  Log Message:
  -----------
  Reimplement ORM_MPTT relationships with a similar API to regular ORM
relationships per a suggestion from Shad[1].

Exmaple before/after pairs:

   $item->children()
-->$item->children->find_all()

   $item->viewable()->children()
-->$item->children->viewable()->find_all()

   $item->children(1, 2, array("type", "=", "album"))
-->$item->children->where("type", "=", "album")->limit(1)->offset(2)->find_all()

Consequences:
- Simpler, more consistent API for dealing with relationships
- Get rid of ORM::unloaded_instance() hack
- Reduced code size
- Longer call chains where it's used

[1] https://github.com/gallery/gallery3/commit/88b6865f472b4203b9ef04d4b99e3310ecb960d2


  Commit: 177af351620337e05a6e0b845981d3237affa68f
      https://github.com/gallery/gallery3/commit/177af351620337e05a6e0b845981d3237affa68f
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-04-29 (Mon, 29 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Model/Item.php

  Log Message:
  -----------
  Add a todo:
      // @TODO: revisit this - it's silly to have a design which allows us to not have an identity
      // provider.


  Commit: f8d56a78e66c99bb85e651d346a87090a3249718
      https://github.com/gallery/gallery3/commit/f8d56a78e66c99bb85e651d346a87090a3249718
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-04-29 (Mon, 29 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Model/Item.php

  Log Message:
  -----------
  Fix indentation.


  Commit: 1309782d05b9064974f83ab06b955c5bf882a9c2
      https://github.com/gallery/gallery3/commit/1309782d05b9064974f83ab06b955c5bf882a9c2
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-04-29 (Mon, 29 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Access.php
    M modules/gallery/classes/Gallery/Hook/GalleryEvent.php
    M modules/gallery/classes/Gallery/Model/Item.php
    M modules/gallery/classes/Gallery/ORM/MPTT.php
    M modules/gallery/tests/Access_Test.php

  Log Message:
  -----------
  Make ORM_MPTT::parent a regular ORM relationship.  This exposes issues
where relationships can get stale and occasionally need to be reloaded
- Access_Test::test_moved_items_inherit_new_permissions started
failing and highlighted it.  So reload some relationships if we
believe that they might be out of date.  This wasn't necessary before
we started making more things relationships (and possibly was one of
the original reasons why we didn't use relationships for this code).


  Commit: acced96c316c3ae73f5caf0fd582b36a3877f21d
      https://github.com/gallery/gallery3/commit/acced96c316c3ae73f5caf0fd582b36a3877f21d
  Author: Bharat Mediratta <[email protected]>
  Date:   2013-04-29 (Mon, 29 Apr 2013)

  Changed paths:
    R modules/formo/views/formo/field_template.php
    R modules/formo/views/formo/form_template.php
    R modules/formo/views/formo/group_template.php
    R modules/formo/views/formo/opts/checkboxes_template.php
    R modules/formo/views/formo/opts/radios_template.php
    R modules/formo/views/formo/opts/select_template.php
    R modules/formo/views/formo_bootstrap/checkbox_template.php
    R modules/formo/views/formo_bootstrap/field_template.php
    R modules/formo/views/formo_bootstrap/form_template.php
    R modules/formo/views/formo_bootstrap/group_template.php
    R modules/formo/views/formo_bootstrap/opts/checkboxes_template.php
    R modules/formo/views/formo_bootstrap/opts/radios_template.php
    R modules/formo/views/formo_bootstrap/opts/select_template.php
    M modules/gallery/classes/Gallery/Formo.php
    M modules/gallery/config/formo.php
    A modules/gallery/views/formo/field_template.php
    A modules/gallery/views/formo/form_template.php
    A modules/gallery/views/formo/group_template.php
    A modules/gallery/views/formo/opts/checkboxes_template.php
    A modules/gallery/views/formo/opts/radios_template.php
    A modules/gallery/views/formo/opts/select_template.php
    M themes/wind/assets/screen-fix-ie.css

  Log Message:
  -----------
  Merge branch 'kohana_3' of github.com:gallery/gallery3 into kohana_3


Compare: https://github.com/gallery/gallery3/compare/d49fca7d909a...acced96c316c

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]