[gallery/gallery3] a19909: Change Formo form/group templates to be more flexi...

  Branch: refs/heads/kohana_3
  Home:   https://github.com/gallery/gallery3
  Commit: a199099bebcd8c5a47c6de9f645691566e3919cf
      https://github.com/gallery/gallery3/commit/a199099bebcd8c5a47c6de9f645691566e3919cf
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-29 (Mon, 29 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Formo.php
    M modules/gallery/views/formo/form_template.php
    M modules/gallery/views/formo/group_template.php

  Log Message:
  -----------
  Change Formo form/group templates to be more flexible.
Previously (consistent with Gallery 3.0.x):
- forms were expected to have either only groups or only non-groups (excepting hidden).
- groups were expected to have only non-groups.
Now (compatible with Gallery 3.0.x, but allows more possibilities):
- forms and groups render hidden things first, non-group things next (in a <ul>),
then groups (which make their own <fieldset>).
- forms can now have a mix of group and non-group elements.
- groups can now have sub-groups inside of them.


  Commit: d14b206fc8701fd4d356e69ec01cd84b95e79f3f
      https://github.com/gallery/gallery3/commit/d14b206fc8701fd4d356e69ec01cd84b95e79f3f
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-29 (Mon, 29 Apr 2013)

  Changed paths:
    M modules/purifier/classes/Purifier.php

  Log Message:
  -----------
  Add note to Purifier to explain why we don't care about special cookie attrs.


  Commit: 84d1df992a25e1ddf8b6ee28249fec30eb1315eb
      https://github.com/gallery/gallery3/commit/84d1df992a25e1ddf8b6ee28249fec30eb1315eb
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-29 (Mon, 29 Apr 2013)

  Changed paths:
    M modules/gallery/views/formo/field_template.php
    M modules/gallery/views/formo/form_template.php
    M modules/gallery/views/formo/group_template.php

  Log Message:
  -----------
  Change indentation in Formo templates to make them more readable.


  Commit: 75eb81ca9a10ab16817e39776d6fa3095f8197fe
      https://github.com/gallery/gallery3/commit/75eb81ca9a10ab16817e39776d6fa3095f8197fe
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    M modules/gallery/views/formo/field_template.php

  Log Message:
  -----------
  Change Formo field template labels to be more strictly compliant.
The <label> "for" attribute should be related to the input id (CSS id), not the
input name ($_POST field), although most browsers are smart enough to figure out
what you mean in either case.  Still, since we don't always give our input
fields ids, we shouldn't rely on this (as it isn't strictly compliant).
Instead, use implicit assignment as <label>Label<input ...></label>.


  Commit: 57a1631d6b53cdf77b73fcc97e669615ee973ca0
      https://github.com/gallery/gallery3/commit/57a1631d6b53cdf77b73fcc97e669615ee973ca0
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/FileProxy.php
    M modules/gallery/classes/Gallery/Hook/Rest/Data.php
    M modules/gallery/classes/Gallery/Response.php

  Log Message:
  -----------
  Overload Response::send_file() to handle base64 encoding.
- add the function, which loads the base64-encoded file into the body.
- revise Hook_Rest_Data to use the new function.
- revise File_Proxy to follow the formatting of above (no functional changes).


  Commit: da81cdeea336ec32b8f6e280498d5dc77a2f82dd
      https://github.com/gallery/gallery3/commit/da81cdeea336ec32b8f6e280498d5dc77a2f82dd
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    M modules/formo/classes/Formo/Core/Innards.php

  Log Message:
  -----------
  Update Formo to include our newest patch (allows named callbacks).


  Commit: 63467414c435091c4cb76ca534f2a2c98731719c
      https://github.com/gallery/gallery3/commit/63467414c435091c4cb76ca534f2a2c98731719c
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Auth.php
    M modules/gallery/classes/Gallery/Controller/Login.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
    M modules/gallery/views/gallery/reauthenticate.html.php

  Log Message:
  -----------
  Big rewrite of Reauthenticate controller, which now looks a lot like Login.
- add Auth::reauthenticate() analogous to Auth::login()
- revise Auth::validate_too_many_failed_logins() so we can use it with both.
- revise Login controller to reflect above.
- tweak reauthenticate view to make variable names more consistent.
- add comments at top of Login and Reauthenticate to discuss similarities/diffs.


  Commit: ec37ce480e24fa1467aa866c940a942645c0387a
      https://github.com/gallery/gallery3/commit/ec37ce480e24fa1467aa866c940a942645c0387a
  Author: Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-04-30 (Tue, 30 Apr 2013)

  Changed paths:
    M modules/formo/classes/Formo/Core/Innards.php
    M modules/gallery/classes/Gallery/Auth.php
    M modules/gallery/classes/Gallery/Controller/FileProxy.php
    M modules/gallery/classes/Gallery/Controller/Login.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
    M modules/gallery/classes/Gallery/Formo.php
    M modules/gallery/classes/Gallery/Hook/Rest/Data.php
    M modules/gallery/classes/Gallery/Response.php
    M modules/gallery/views/formo/field_template.php
    M modules/gallery/views/formo/form_template.php
    M modules/gallery/views/formo/group_template.php
    M modules/gallery/views/gallery/reauthenticate.html.php
    M modules/purifier/classes/Purifier.php

  Log Message:
  -----------
  Merge pull request #331 from shadlaws/fixes_20130430

Fixes 20130430


Compare: https://github.com/gallery/gallery3/compare/f5a0d58fead9...ec37ce480e24

------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]