[gallery/gallery3] 7f78d0: Move js variable MSG_CANCEL definition from themes...

  Branch: refs/heads/kohana_3
  Home:   https://github.com/gallery/gallery3
  Commit: 7f78d0ca52b6a149236f3ca4d5896659fa4bcfbe
      https://github.com/gallery/gallery3/commit/7f78d0ca52b6a149236f3ca4d5896659fa4bcfbe
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-06 (Mon, 06 May 2013)

  Changed paths:
    M lib/gallery.dialog.js
    M lib/gallery.in_place_edit.js
    M modules/gallery/classes/Gallery/Hook/GalleryTheme.php
    M themes/admin_wind/views/required/admin.html.php
    M themes/wind/views/required/page.html.php

  Log Message:
  -----------
  Move js variable MSG_CANCEL definition from themes to Hook_GalleryTheme.
Now, it's always present so we don't need to check for its existence.


  Commit: f28b6a376b1c52bc491da7b1e9fbe87d930622a2
      https://github.com/gallery/gallery3/commit/f28b6a376b1c52bc491da7b1e9fbe87d930622a2
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-06 (Mon, 06 May 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Model/Item.php

  Log Message:
  -----------
  Fix indentation in Model_Item::rules()


  Commit: c388fd920b96e9ff636da28a687159c845a7c519
      https://github.com/gallery/gallery3/commit/c388fd920b96e9ff636da28a687159c845a7c519
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-06 (Mon, 06 May 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Formo/Driver/ORM/Kohana.php

  Log Message:
  -----------
  Revise our Formo/ORM driver - rethrow the ORM_Validation_Exception if we don't
have a corresponding field in the form.


  Commit: 4247eef6fd58a6fe94036be81da63a1c87385392
      https://github.com/gallery/gallery3/commit/4247eef6fd58a6fe94036be81da63a1c87385392
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-06 (Mon, 06 May 2013)

  Changed paths:
    M modules/comment/classes/Comment/Model/Comment.php
    M modules/comment/tests/Comment_Model_Test.php

  Log Message:
  -----------
  Revise Model_Comment for K3.
- use rules() instead of validate() to set rules.
- replace some callbacks with standard valid functions.
- only add guest name/email/url rules if the author is a guest.
- blank guest name/email/url if the author isn't a guest.
- change how we set the $_SERVER vars - add isset() calls, use foreach.
- make valid_state() no longer static, just like the other item/comment rules.
(I searched gallery3 and gallery3-contrib and found no place this was called
other than Model_Comment.)
- revise unit tests - they pass!


  Commit: a8b4f822e85b5d28d35df56fddf0b80633461552
      https://github.com/gallery/gallery3/commit/a8b4f822e85b5d28d35df56fddf0b80633461552
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-06 (Mon, 06 May 2013)

  Changed paths:
    M modules/comment/classes/Comment/Comment.php
    M modules/comment/classes/Comment/Controller/Comments.php
    M modules/comment/views/comment/block.html.php

  Log Message:
  -----------
  Convert Controller_Comments to Formo, clean up links in comment block.


  Commit: 430efc01321aa3332144357005e3483757a11371
      https://github.com/gallery/gallery3/commit/430efc01321aa3332144357005e3483757a11371
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-06 (Mon, 06 May 2013)

  Changed paths:
    M modules/comment/tests/Comment_Helper_Test.php

  Log Message:
  -----------
  Add @todo note to Comment_Helper_Test - they're really model tests...


  Commit: fc18b0c803659a1d0564144df079f5b5dd06b0e5
      https://github.com/gallery/gallery3/commit/fc18b0c803659a1d0564144df079f5b5dd06b0e5
  Author: Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-06 (Mon, 06 May 2013)

  Changed paths:
    M lib/gallery.dialog.js
    M lib/gallery.in_place_edit.js
    M modules/comment/classes/Comment/Comment.php
    M modules/comment/classes/Comment/Controller/Comments.php
    M modules/comment/classes/Comment/Model/Comment.php
    M modules/comment/tests/Comment_Helper_Test.php
    M modules/comment/tests/Comment_Model_Test.php
    M modules/comment/views/comment/block.html.php
    M modules/gallery/classes/Gallery/Formo/Driver/ORM/Kohana.php
    M modules/gallery/classes/Gallery/Hook/GalleryTheme.php
    M modules/gallery/classes/Gallery/Model/Item.php
    M themes/admin_wind/views/required/admin.html.php
    M themes/wind/views/required/page.html.php

  Log Message:
  -----------
  Merge pull request #354 from shadlaws/comments_controller

Comments controller


Compare: https://github.com/gallery/gallery3/compare/30a6b717f071...fc18b0c80365

------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]