[gallery/gallery3] d490ce: Ensure auth still happens if empty username/passwo...
GitHub <noreply-9UaJU3cA/F/[email protected]> Thu, 09 May 2013 09:16:08 -0700
| Newsgroups | gmane.comp.web.gallery.cvs |
|---|---|
| Message-ID | <518bcbc8d8108_1e726fbddc996c2@hookshot-fe1-pe1-prd.aws.github.net.mail> |
Branch: refs/heads/kohana_3
Home: https://github.com/gallery/gallery3
Commit: d490ce12d2070de0ac7137818dd6f69e46bf4f33
https://github.com/gallery/gallery3/commit/d490ce12d2070de0ac7137818dd6f69e46bf4f33
Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
Date: 2013-05-09 (Thu, 09 May 2013)
Changed paths:
M modules/gallery/classes/Gallery/Controller/Login.php
M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
Log Message:
-----------
Ensure auth still happens if empty username/password are given.
@see Validation::$_empty_rules, Validation::check()
- add "not_empty" rules to login and reauthenticate controllers.
- use same error messages as typical invalid entries.
Commit: 10e56c286c9181fe3e38891426392124e5b65053
https://github.com/gallery/gallery3/commit/10e56c286c9181fe3e38891426392124e5b65053
Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
Date: 2013-05-09 (Thu, 09 May 2013)
Changed paths:
M modules/gallery/classes/Gallery/Controller.php
Log Message:
-----------
Ensure that we use the "is_ajax_request" Session parameter.
Now re-auth with the server_add dialog works properly.
Commit: 74b6dae280f7c8775b74ec6ee899b17e26eaf0f3
https://github.com/gallery/gallery3/commit/74b6dae280f7c8775b74ec6ee899b17e26eaf0f3
Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
Date: 2013-05-09 (Thu, 09 May 2013)
Changed paths:
M modules/gallery/classes/Gallery/Formo.php
Log Message:
-----------
Add Formo::merge_groups() to, well, merge two groups.
Commit: 08cf7f3355a5d50c4fd4bb85478bc6530a5331e3
https://github.com/gallery/gallery3/commit/08cf7f3355a5d50c4fd4bb85478bc6530a5331e3
Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
Date: 2013-05-09 (Thu, 09 May 2013)
Changed paths:
M modules/comment/classes/Comment/Controller/Comments.php
M modules/gallery/classes/Gallery/Controller/Items.php
Log Message:
-----------
Make use of model/other groups consistent in Comments and Items controllers.
- use one group for ORM values, one for other stuff (tags, recaptcha, submit...)
- use Formo::merge_groups() to merge them just before presentation.
This does a better job of partitioning the model, which seems like a cleaner
and more robust approach.
Commit: b6954955f1a157debbdc364a8980cc88971e5c92
https://github.com/gallery/gallery3/commit/b6954955f1a157debbdc364a8980cc88971e5c92
Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
Date: 2013-05-09 (Thu, 09 May 2013)
Changed paths:
M modules/comment/classes/Comment/Controller/Admin/ManageComments.php
M modules/g2_import/classes/G2Import/G2Import.php
M modules/gallery/classes/Gallery/Hook/GalleryInstaller.php
M modules/gallery/classes/Gallery/Hook/GalleryTask.php
Log Message:
-----------
Fix DB::select() syntax with arrays to "DB::select(array($column, $alias))"
Commit: 1cad9609619cc5c2bf8b2d8fb5579a3676256234
https://github.com/gallery/gallery3/commit/1cad9609619cc5c2bf8b2d8fb5579a3676256234
Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
Date: 2013-05-09 (Thu, 09 May 2013)
Changed paths:
M modules/gallery/classes/Gallery/Hook/GalleryTask.php
Log Message:
-----------
Fix select in Hook_GalleryTask::find_missing_access_caches_limited().
Commit: a649408678c5b5e06dc9870d778cea20dbd16148
https://github.com/gallery/gallery3/commit/a649408678c5b5e06dc9870d778cea20dbd16148
Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
Date: 2013-05-09 (Thu, 09 May 2013)
Changed paths:
M modules/exif/classes/Exif/Exif.php
M modules/exif/classes/Exif/Hook/ExifTask.php
M modules/gallery/classes/Gallery/Access.php
M modules/gallery/classes/Gallery/Hook/GalleryInstaller.php
M modules/notification/classes/Notification/Notification.php
Log Message:
-----------
Be more specific with select/where fields when using ORM::with().
Many of these changes may be unnecessary, but it seems easier to be more
precise across the board instead of carefully debugging each case individually.
Commit: 3b61119110e743fdad21bf67b12360eb887b7079
https://github.com/gallery/gallery3/commit/3b61119110e743fdad21bf67b12360eb887b7079
Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
Date: 2013-05-09 (Thu, 09 May 2013)
Changed paths:
M modules/gallery/classes/Gallery/Hook/GalleryTask.php
Log Message:
-----------
Change "Fix your Gallery" task go faster and be more comprehensive.
- optimize MPTT pointer rebuilding for leaf nodes (i.e. non-albums).
- reverse order_by to try and preserve existing tree ordering.
- reset item level while we're here.
- use "$stack[] = 123" instead of array_push($stack, 123) since it's faster.
Commit: 1b39c076ae542bba0a8c2af238b27a8266160166
https://github.com/gallery/gallery3/commit/1b39c076ae542bba0a8c2af238b27a8266160166
Author: Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
Date: 2013-05-09 (Thu, 09 May 2013)
Changed paths:
M modules/comment/classes/Comment/Controller/Admin/ManageComments.php
M modules/comment/classes/Comment/Controller/Comments.php
M modules/exif/classes/Exif/Exif.php
M modules/exif/classes/Exif/Hook/ExifTask.php
M modules/g2_import/classes/G2Import/G2Import.php
M modules/gallery/classes/Gallery/Access.php
M modules/gallery/classes/Gallery/Controller.php
M modules/gallery/classes/Gallery/Controller/Items.php
M modules/gallery/classes/Gallery/Controller/Login.php
M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
M modules/gallery/classes/Gallery/Formo.php
M modules/gallery/classes/Gallery/Hook/GalleryInstaller.php
M modules/gallery/classes/Gallery/Hook/GalleryTask.php
M modules/notification/classes/Notification/Notification.php
Log Message:
-----------
Merge pull request #343 from shadlaws/make_fix_your_gallery_less_slow
Make "Fix your Gallery" task go faster with non-album MPTT pointer rebuilding.
Compare: https://github.com/gallery/gallery3/compare/bc0087d7d809...1b39c076ae54
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
__[ g a l l e r y - c h e c k i n s ]_________________________
[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]