[gallery/gallery3] acbb3f: Followon from previous commit: clean up error mess...

GitHub <noreply-9UaJU3cA/F/[email protected]> Mon, 13 May 2013 10:17:11 -0700
Newsgroups gmane.comp.web.gallery.cvs
Message-ID <51912017b20f8_114b1211dd441394@hookshot-fe3-pe1-prd.aws.github.net.mail>
  Branch: refs/heads/kohana_3
  Home:   https://github.com/gallery/gallery3
  Commit: acbb3fed5e009c810d6f4996d046f0571302fb36
      https://github.com/gallery/gallery3/commit/acbb3fed5e009c810d6f4996d046f0571302fb36
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M modules/user/classes/User/Controller/Users.php

  Log Message:
  -----------
  Followon from previous commit: clean up error message helper calls.


  Commit: 94b9d04feea22393251129fe2e430de744bf6516
      https://github.com/gallery/gallery3/commit/94b9d04feea22393251129fe2e430de744bf6516
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M modules/user/classes/User/Controller/Admin/Users.php

  Log Message:
  -----------
  Followon from previous commit: remove unneeded message (form already has errors)


  Commit: 4fc703bc929e4099c6a58bfa5a73885e8153912e
      https://github.com/gallery/gallery3/commit/4fc703bc929e4099c6a58bfa5a73885e8153912e
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Auth.php
    M modules/gallery/classes/Gallery/Controller/Login.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
    M modules/gallery/classes/Gallery/Hook/GalleryEvent.php
    M modules/rest/classes/Rest/Controller/Rest.php
    M modules/user/classes/User/Controller/Users.php

  Log Message:
  -----------
  Refactor auth/login/reauthenticate a bit.
- left same net results, same events fired, and same messages sent.
- collected all auth-related code in Auth class
(from Hook_GalleryEvent, Login/Reauthenticate/Rest/Users controllers).
- streamlined API using validation rules.
- put error messages in callbacks so they can be used elsewhere
(e.g. reauthenticate to change email/password).


  Commit: c2f28645547646661774a25489d59a0dbb2bbbd0
      https://github.com/gallery/gallery3/commit/c2f28645547646661774a25489d59a0dbb2bbbd0
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M modules/gallery/views/formo/form_template.html.php
    M modules/gallery/views/formo/group_template.html.php

  Log Message:
  -----------
  Revise Formo templates - improve how form/group $title and html() are rendered.


  Commit: 2d0e6c1d9d8542f0ae31d5208cbaeb0dfdb320d0
      https://github.com/gallery/gallery3/commit/2d0e6c1d9d8542f0ae31d5208cbaeb0dfdb320d0
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
    R modules/gallery/views/gallery/reauthenticate.html.php

  Log Message:
  -----------
  Revise Reauthenticate form rendering - now works as typical ajax dialog.
- use Response::ajax_form(), just like almost all other ajax forms in Gallery.
- remove separate view file.


  Commit: 9405e5cf6d43b6efe1a9397a2858146033987c7e
      https://github.com/gallery/gallery3/commit/9405e5cf6d43b6efe1a9397a2858146033987c7e
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Login.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php

  Log Message:
  -----------
  Add events to login and reauthenticate forms (useful for forgot password, register new user, etc.).


  Commit: e98c70fe8d994c2173147188bad30d430a2932a6
      https://github.com/gallery/gallery3/commit/e98c70fe8d994c2173147188bad30d430a2932a6
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Login.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php

  Log Message:
  -----------
  Fix continue_url in login and reauthenticate so it isn't persistent.


  Commit: d8b128abe8402195eea2303e09dc6b48b76b1167
      https://github.com/gallery/gallery3/commit/d8b128abe8402195eea2303e09dc6b48b76b1167
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M lib/gallery.common.js

  Log Message:
  -----------
  Fix formatting in gallery.common.js.


  Commit: f9ec8b62f89ef7bc93bea8787b18d51ebb05ad06
      https://github.com/gallery/gallery3/commit/f9ec8b62f89ef7bc93bea8787b18d51ebb05ad06
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M lib/gallery.dialog.js
    M themes/admin_wind/assets/screen.css
    M themes/wind/assets/screen.css

  Log Message:
  -----------
  Allow dialog links inside dialogs to replace the dialog (e.g. "forgot password" link in login)


  Commit: 1a37677f1f935915394cb430386596d933ec4419
      https://github.com/gallery/gallery3/commit/1a37677f1f935915394cb430386596d933ec4419
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M themes/admin_wind/assets/screen.css
    M themes/wind/assets/screen.css

  Log Message:
  -----------
  Make non-ajax form spacing more consistent with ajax forms.


  Commit: 7c800693ee99939c5dc437761d4e2ddd16d1fe8f
      https://github.com/gallery/gallery3/commit/7c800693ee99939c5dc437761d4e2ddd16d1fe8f
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Formo.php

  Log Message:
  -----------
  Add Formo::add_after_submit(), which works just like Formo::add_before_submit().


  Commit: fc615c19f800f9bf548f1fce03acb182de23af3d
      https://github.com/gallery/gallery3/commit/fc615c19f800f9bf548f1fce03acb182de23af3d
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Login.php
    R modules/gallery/views/gallery/login.html.php
    M modules/user/classes/User/Controller/Password.php
    M modules/user/classes/User/Hook/UserEvent.php

  Log Message:
  -----------
  Revise Login form rendering, move "forgot password" link to user module.
- they now work as typical ajax dialogs, just like reauthenticate.


  Commit: 65770cfec31b26cf837208240d2ba0951915dcdc
      https://github.com/gallery/gallery3/commit/65770cfec31b26cf837208240d2ba0951915dcdc
  Author: Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-13 (Mon, 13 May 2013)

  Changed paths:
    M lib/gallery.common.js
    M lib/gallery.dialog.js
    M modules/gallery/classes/Gallery/Auth.php
    M modules/gallery/classes/Gallery/Controller/Login.php
    M modules/gallery/classes/Gallery/Controller/Reauthenticate.php
    M modules/gallery/classes/Gallery/Formo.php
    M modules/gallery/classes/Gallery/Hook/GalleryEvent.php
    M modules/gallery/views/formo/form_template.html.php
    M modules/gallery/views/formo/group_template.html.php
    R modules/gallery/views/gallery/login.html.php
    R modules/gallery/views/gallery/reauthenticate.html.php
    M modules/rest/classes/Rest/Controller/Rest.php
    M modules/user/classes/User/Controller/Admin/Users.php
    M modules/user/classes/User/Controller/Password.php
    M modules/user/classes/User/Controller/Users.php
    M modules/user/classes/User/Hook/UserEvent.php
    M themes/admin_wind/assets/screen.css
    M themes/wind/assets/screen.css

  Log Message:
  -----------
  Merge pull request #365 from shadlaws/fixes_20130513

Fixes 20130513


Compare: https://github.com/gallery/gallery3/compare/27ee09e1f114...65770cfec31b

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]