[gallery/gallery3] 885a43: Add some comments to the tag module controllers.

GitHub <noreply-9UaJU3cA/F/[email protected]> Thu, 30 May 2013 03:57:40 -0700
Newsgroups	gmane.comp.web.gallery.cvs
Message-ID	<51a730a4ee7a2_29c612a7dd491634@hookshot-fe4-pe1-prd.aws.github.net.mail>
  Branch: refs/heads/kohana_3
  Home:   https://github.com/gallery/gallery3
  Commit: 885a43dce15c758d66bde4575a8f47e6f1ac3956
      https://github.com/gallery/gallery3/commit/885a43dce15c758d66bde4575a8f47e6f1ac3956
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-16 (Thu, 16 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    M modules/tag/classes/Tag/Controller/Tag.php
    M modules/tag/classes/Tag/Controller/Tags.php

  Log Message:
  -----------
  Add some comments to the tag module controllers.


  Commit: 8f680713a12fc1d1716dbfe9a6cca43ac07535a6
      https://github.com/gallery/gallery3/commit/8f680713a12fc1d1716dbfe9a6cca43ac07535a6
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-16 (Thu, 16 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    M modules/tag/classes/Tag/Controller/Tags.php

  Log Message:
  -----------
  Change tag name length limit in forms from 64 to 128 to match model.


  Commit: 7970cb6b3a236bea21a2aafaac4a8bb05b3ef15c
      https://github.com/gallery/gallery3/commit/7970cb6b3a236bea21a2aafaac4a8bb05b3ef15c
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-16 (Thu, 16 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Admin/Tags.php

  Log Message:
  -----------
  Change naming of form field in admin/tags/edit action (minor, internal change)


  Commit: 7281e2107d4539f9493b7f16683d2e1566139967
      https://github.com/gallery/gallery3/commit/7281e2107d4539f9493b7f16683d2e1566139967
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-17 (Fri, 17 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    M modules/tag/views/admin/tags.html.php

  Log Message:
  -----------
  Change "admin/tags/edit" --> "admin/tags/edit_name".  Also, make the view's
in_place_editi-ifying code a bit more specific.


  Commit: 7e4bb7595b5a33ac901846ffb5154589da5f9d4b
      https://github.com/gallery/gallery3/commit/7e4bb7595b5a33ac901846ffb5154589da5f9d4b
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-17 (Fri, 17 May 2013)

  Changed paths:
    M modules/formo/classes/Formo/Core/Innards.php

  Log Message:
  -----------
  Followon to "self" --> "static" change - revert accidental changes to Formo.


  Commit: 25d196b9c6224bc9f9e1a624442330aabaddd9b7
      https://github.com/gallery/gallery3/commit/25d196b9c6224bc9f9e1a624442330aabaddd9b7
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Controller/Items.php
    M modules/tag/assets/tag.css
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    M modules/tag/classes/Tag/Controller/Tag.php
    M modules/tag/classes/Tag/Hook/TagInstaller.php
    M modules/tag/classes/Tag/Model/Tag.php
    M modules/tag/init.php
    M modules/tag/module.info
    M modules/tag/views/admin/tags.html.php

  Log Message:
  -----------
  Use tag slugs to define tag URLs instead of ids.
- add slug to model, along with business logic.
- change tag URLs to use slugs in model and init (routing)
- change installer to add slugs to existing tags.
- change tag admin screen to show URLs.
- add edit form to admin screen to allow direct editing of URLs (and names).
- add comments to Controller_Items referring to tag edit form.
- @todo: add slug-related unit tests, add multi-tag routing, add tag album.
- @todo: move Item::convert_filename_to_slug() and Controller_Tag methods.


  Commit: 9b8995e56514aec2dabce7bd71f5410133568bb6
      https://github.com/gallery/gallery3/commit/9b8995e56514aec2dabce7bd71f5410133568bb6
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    M modules/tag/classes/Tag/Controller/Tags.php

  Log Message:
  -----------
  Consolidate a couple tag error message definitions.


  Commit: d61ec3efa564472ea05eebe40a69a847abc81267
      https://github.com/gallery/gallery3/commit/d61ec3efa564472ea05eebe40a69a847abc81267
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Tags.php

  Log Message:
  -----------
  Remove unneeded hidden form field in Controller_Tags::action_add().


  Commit: dbdfbc29d08e4063d492aedbb83c55b8ffa2e7e7
      https://github.com/gallery/gallery3/commit/dbdfbc29d08e4063d492aedbb83c55b8ffa2e7e7
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/g2_import/classes/G2Import/Controller/G2.php
    M modules/gallery/classes/Gallery/Controller/Items.php
    R modules/tag/classes/Controller/Tag.php
    R modules/tag/classes/Tag/Controller/Tag.php
    M modules/tag/classes/Tag/Controller/Tags.php
    M modules/tag/init.php

  Log Message:
  -----------
  Merge Controller_Tag into Controller_Tags.  There's no reason to separate these.


  Commit: 2dd1f5e8b0e3eac8bfcb96e696966c4508d72639
      https://github.com/gallery/gallery3/commit/2dd1f5e8b0e3eac8bfcb96e696966c4508d72639
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Tags.php

  Log Message:
  -----------
  Refactor how Controller_Tags::action_show() interprets the route a bit.


  Commit: af056b6de63edced1a2611f725d13eb3b8154abe
      https://github.com/gallery/gallery3/commit/af056b6de63edced1a2611f725d13eb3b8154abe
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/tag/views/admin/tags.html.php

  Log Message:
  -----------
  Fix formatting in admin/tags view.


  Commit: 85531a01c8b0a31f87f4279d772d9ae3e8b2eaad
      https://github.com/gallery/gallery3/commit/85531a01c8b0a31f87f4279d772d9ae3e8b2eaad
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Tags.php

  Log Message:
  -----------
  Revise how pagination in Controller_Tags::action_show() gets tag URL.


  Commit: 250a5468baa6f4b4bea90e9e6e5fe1b3c68703e0
      https://github.com/gallery/gallery3/commit/250a5468baa6f4b4bea90e9e6e5fe1b3c68703e0
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Tags.php
    M modules/tag/classes/Tag/Hook/Rest/Tag.php
    M modules/tag/classes/Tag/Hook/Rest/TagItems.php
    M modules/tag/classes/Tag/Hook/TagRss.php
    M modules/tag/classes/Tag/Model/Tag.php

  Log Message:
  -----------
  Remove Model_Tag::items(), similar to Model_Item::children() removal.


  Commit: 2739126dd8e33ff654549a3de44dc0e3fb809ab6
      https://github.com/gallery/gallery3/commit/2739126dd8e33ff654549a3de44dc0e3fb809ab6
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Controller/Tags.php
    M modules/tag/classes/Tag/Hook/TagTask.php
    M modules/tag/classes/Tag/Model/Tag.php

  Log Message:
  -----------
  Remove Model_Tag::items_count(), similar to Model_Item::children_count() removal


  Commit: 8d0a4f2240c2493f72df61b4f70348e65939b377
      https://github.com/gallery/gallery3/commit/8d0a4f2240c2493f72df61b4f70348e65939b377
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/tag/classes/Tag/Hook/TagRss.php

  Log Message:
  -----------
  Make tag RSS show all non-album items (instead of only photos).  Very old bug...


  Commit: 91a3f13556772e42f99981cb0bf4e5081c84f0b3
      https://github.com/gallery/gallery3/commit/91a3f13556772e42f99981cb0bf4e5081c84f0b3
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M modules/formo/classes/Formo/Core/Formo.php

  Log Message:
  -----------
  Update Formo to newest master branch (in sync with vendor).


  Commit: 14d2f1036163a1f273e45b85023f0822ca96ad4b
      https://github.com/gallery/gallery3/commit/14d2f1036163a1f273e45b85023f0822ca96ad4b
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M index.php
    M modules/gallery/classes/Gallery/Controller/Packager.php

  Log Message:
  -----------
  Revise packager for Gallery 3.1.
- change PATH_INFO in index.php (similar to unit test).
- add ORM::reinitialize() before re-installation (similar to unit test).
- revise database connection element names.
- add HTMLPurifier cache to ignored paths for init_var.php generation.


  Commit: fee1645d32f238b1d2fad51e12a2e0872a82a5b3
      https://github.com/gallery/gallery3/commit/fee1645d32f238b1d2fad51e12a2e0872a82a5b3
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M installer/init_var.php
    M installer/install.sql

  Log Message:
  -----------
  Update install.sql and init_var.php using now-fixed packager.
- updated graphics rules (class name, Image::AUTO integer).
- updated tag module version.
- updated tag table fields.
- add cache directory to init_var.


  Commit: 99b3ac181da96aee9c26e843193fd4eca08d6b88
      https://github.com/gallery/gallery3/commit/99b3ac181da96aee9c26e843193fd4eca08d6b88
  Author: Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-05-30 (Thu, 30 May 2013)

  Changed paths:
    M index.php
    M installer/init_var.php
    M installer/install.sql
    M modules/formo/classes/Formo/Core/Formo.php
    M modules/formo/classes/Formo/Core/Innards.php
    M modules/g2_import/classes/G2Import/Controller/G2.php
    M modules/gallery/classes/Gallery/Controller/Items.php
    M modules/gallery/classes/Gallery/Controller/Packager.php
    M modules/tag/assets/tag.css
    R modules/tag/classes/Controller/Tag.php
    M modules/tag/classes/Tag/Controller/Admin/Tags.php
    R modules/tag/classes/Tag/Controller/Tag.php
    M modules/tag/classes/Tag/Controller/Tags.php
    M modules/tag/classes/Tag/Hook/Rest/Tag.php
    M modules/tag/classes/Tag/Hook/Rest/TagItems.php
    M modules/tag/classes/Tag/Hook/TagInstaller.php
    M modules/tag/classes/Tag/Hook/TagRss.php
    M modules/tag/classes/Tag/Hook/TagTask.php
    M modules/tag/classes/Tag/Model/Tag.php
    M modules/tag/init.php
    M modules/tag/module.info
    M modules/tag/views/admin/tags.html.php

  Log Message:
  -----------
  Merge pull request #372 from shadlaws/tag_rerouting

Tag rerouting, packager, Formo


Compare: https://github.com/gallery/gallery3/compare/a65fbc066075...99b3ac181da9

------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]