[gallery/gallery3] f3b0fb: Don't rawurlencode item/tag slugs - they're alread...

  Branch: refs/heads/kohana_3
  Home:   https://github.com/gallery/gallery3
  Commit: f3b0fba1c6e820b1cce0d4ff1cbf99bc2da35238
      https://github.com/gallery/gallery3/commit/f3b0fba1c6e820b1cce0d4ff1cbf99bc2da35238
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Model/Item.php
    M modules/tag/classes/Tag/Model/Tag.php

  Log Message:
  -----------
  Don't rawurlencode item/tag slugs - they're already URL-safe.


  Commit: c828ded0d8cd8d461180da77c57b33952d9b48cd
      https://github.com/gallery/gallery3/commit/c828ded0d8cd8d461180da77c57b33952d9b48cd
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/IdentityProvider.php
    M modules/gallery/classes/Gallery/Model/Item.php

  Log Message:
  -----------
  Fix two Exception --> Gallery_Exception.


  Commit: 51e61a8dee25feea250d6a283e08854b2804fd73
      https://github.com/gallery/gallery3/commit/51e61a8dee25feea250d6a283e08854b2804fd73
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Gallery/Exception.php

  Log Message:
  -----------
  Make Gallery_Exception extend Kohana_Extension instead of Exception.
This unifies the error views (which, among other things, makes REST errors
easier to handle).


  Commit: ed84c6a5bc16651d577d0b2e1733ec65c7ee1eb4
      https://github.com/gallery/gallery3/commit/ed84c6a5bc16651d577d0b2e1733ec65c7ee1eb4
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    A modules/rest/classes/Controller/RestUser.php
    M modules/rest/classes/Rest/Controller/Rest.php
    A modules/rest/classes/Rest/Controller/RestUser.php
    M modules/rest/views/rest/user_profile.html.php

  Log Message:
  -----------
  Move "rest/reset_api_key" form to "rest_user/reset_access_key".
This action is part of the standard UI, not the REST API.
Also, change the name to match Rest::reset_access_key().


  Commit: 1216b18282ee5e694bf87ca4d996fbb32f383154
      https://github.com/gallery/gallery3/commit/1216b18282ee5e694bf87ca4d996fbb32f383154
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Controller/Rest.php
    A modules/rest/classes/Controller/Rest/Login.php
    M modules/rest/classes/Rest/Controller/Rest.php
    A modules/rest/classes/Rest/Controller/Rest/Login.php
    A modules/rest/init.php

  Log Message:
  -----------
  Setup Controller_Rest as an abstract class which is never called directly.
- change class declarations.
- move login from base class to Controller_Rest_Login (uses same URL as before).
- add init.php to route rest URLs (default controller is login).
- fire 405 Method Not Allowed for invalid actions.


  Commit: cb0bd2cd01b2f29dd2cd7acd614b8a32feb62428
      https://github.com/gallery/gallery3/commit/cb0bd2cd01b2f29dd2cd7acd614b8a32feb62428
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Controller/Rest.php
    M modules/rest/classes/Rest/Rest/Exception.php
    M modules/rest/init.php
    M modules/rest/views/rest/error.json.php

  Log Message:
  -----------
  Revise how the REST API handles exceptions.
- change error view to restful version in init.php.
- add Controller_Rest::execute() to convert any Exception to a Rest_Exception.
The way it handles ORM_Validation_Exception objects is just like before.
- change Rest_Exception to extend HTTP_Exception.
- revise error view.


  Commit: 2d500e86daa309887faededfa5d50cab5643d7bc
      https://github.com/gallery/gallery3/commit/2d500e86daa309887faededfa5d50cab5643d7bc
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Controller/Rest.php
    M modules/rest/init.php

  Log Message:
  -----------
  Revise how Controller_Rest detects the method and sets the action.


  Commit: 1d6ba537d348659ebec197c9b1df79b1b8f1c845
      https://github.com/gallery/gallery3/commit/1d6ba537d348659ebec197c9b1df79b1b8f1c845
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Hook/RestEvent.php
    M modules/rest/classes/Rest/Rest.php

  Log Message:
  -----------
  Centralize rest key generation in Rest::access_key(), always use salt.
Before, it was defined independently in 4 places, 3 of which didn't use
Access::private_key() as a salt...


  Commit: 3eb802c23ba446c29536de02570a6f69ad8aad96
      https://github.com/gallery/gallery3/commit/3eb802c23ba446c29536de02570a6f69ad8aad96
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Hook/RestEvent.php

  Log Message:
  -----------
  Fold Hook_RestEvent::_get_access_key_form() into user_edit_form_admin().
It's not used anywhere else.


  Commit: dde37ddbe6770966d9f58be75b488ba47b4e478d
      https://github.com/gallery/gallery3/commit/dde37ddbe6770966d9f58be75b488ba47b4e478d
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Controller/Rest.php

  Log Message:
  -----------
  Add Controller_Rest::check_auth() to get the access key and login the user.


  Commit: 7c0a094476f66cd2ff115845b3d16bde3e646dcb
      https://github.com/gallery/gallery3/commit/7c0a094476f66cd2ff115845b3d16bde3e646dcb
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Controller/Rest.php

  Log Message:
  -----------
  Add some class comments to Controller_Rest (these will likely get longer later).


  Commit: 31b51ddc2d885530ec3ee2295520950c9b0ebe24
      https://github.com/gallery/gallery3/commit/31b51ddc2d885530ec3ee2295520950c9b0ebe24
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Controller/Rest.php

  Log Message:
  -----------
  Add file upload processing to Controller_Rest::before().


  Commit: 5505e9882db4b544ebe54fe9aed2a44ce746b0e3
      https://github.com/gallery/gallery3/commit/5505e9882db4b544ebe54fe9aed2a44ce746b0e3
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Controller/Rest.php

  Log Message:
  -----------
  Add entity and members processing to Controller_Rest::before().


  Commit: 64224641ea41dc5715b2f74fa3cb32caf9bc3a17
      https://github.com/gallery/gallery3/commit/64224641ea41dc5715b2f74fa3cb32caf9bc3a17
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Controller/Rest.php

  Log Message:
  -----------
  Rename soon-to-be-deleted Controller_Rest::__call().
I'm keeping it now for reference, so rename to avoid confusion.


  Commit: 88136289411d221496a4273287dd7df216a2bfe1
      https://github.com/gallery/gallery3/commit/88136289411d221496a4273287dd7df216a2bfe1
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Controller/Rest.php
    M modules/rest/classes/Rest/Rest/Exception.php
    M modules/rest/views/rest/error.json.php

  Log Message:
  -----------
  Refactor Rest_Exception (again).
- fix bugs.
- remove log entry from Rest_Exception - Kohana_Exception already does this.
- strip down Rest_Exception::factory() so it's only difference is storing
the message as an array if needed.
- move formatting of output array to error view.


  Commit: ce80ef3264275b0c4421c9675dfa8028cebd73be
      https://github.com/gallery/gallery3/commit/ce80ef3264275b0c4421c9675dfa8028cebd73be
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Hook/Rest/Data.php
    M modules/gallery/classes/Gallery/Hook/Rest/Item.php
    M modules/rest/classes/Rest/Controller/Rest.php
    M modules/rest/classes/Rest/Rest.php
    M modules/tag/classes/Tag/Hook/Rest/Tags.php

  Log Message:
  -----------
  Revise Rest_Exception calls to use new factory method.


  Commit: d9667c6d7916555768d9438694b2f83f31eff0a0
      https://github.com/gallery/gallery3/commit/d9667c6d7916555768d9438694b2f83f31eff0a0
  Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/rest/classes/Rest/Controller/Rest.php

  Log Message:
  -----------
  Revise Rest_Exception calls in Rest_Controller::before()/execute().


  Commit: 08d2229606c8302e225507b20839fd64b8a379fb
      https://github.com/gallery/gallery3/commit/08d2229606c8302e225507b20839fd64b8a379fb
  Author: Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]>
  Date:   2013-06-03 (Mon, 03 Jun 2013)

  Changed paths:
    M modules/gallery/classes/Gallery/Gallery/Exception.php
    M modules/gallery/classes/Gallery/Hook/Rest/Data.php
    M modules/gallery/classes/Gallery/Hook/Rest/Item.php
    M modules/gallery/classes/Gallery/IdentityProvider.php
    M modules/gallery/classes/Gallery/Model/Item.php
    M modules/rest/classes/Controller/Rest.php
    A modules/rest/classes/Controller/Rest/Login.php
    A modules/rest/classes/Controller/RestUser.php
    M modules/rest/classes/Rest/Controller/Rest.php
    A modules/rest/classes/Rest/Controller/Rest/Login.php
    A modules/rest/classes/Rest/Controller/RestUser.php
    M modules/rest/classes/Rest/Hook/RestEvent.php
    M modules/rest/classes/Rest/Rest.php
    M modules/rest/classes/Rest/Rest/Exception.php
    A modules/rest/init.php
    M modules/rest/views/rest/error.json.php
    M modules/rest/views/rest/user_profile.html.php
    M modules/tag/classes/Tag/Hook/Rest/Tags.php
    M modules/tag/classes/Tag/Model/Tag.php

  Log Message:
  -----------
  Merge pull request #380 from shadlaws/fixes_20130603

Fixes 20130603


Compare: https://github.com/gallery/gallery3/compare/7f76ee37be1c...08d2229606c8

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2

__[ g a l l e r y - c h e c k i n s ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]