[gallery/gallery3] 5460d6: Remove unused Item::move(). To move an item, just...
GitHub <noreply-9UaJU3cA/F/[email protected]> Thu, 11 Jul 2013 08:15:18 -0700
| Newsgroups | gmane.comp.web.gallery.cvs |
|---|---|
| Message-ID | <51decc066a3c6_4d6d695dd481c4@hookshot-fe6-pe1-prd.aws.github.net.mail> |
----==_mimepart_51decc06661a8_4d6d695dd4797b Date: Thu, 11 Jul 2013 08:15:18 -0700 Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-ID: <51decc06699dc_4d6d695dd480da-P8FJ25gi/wh9XwKtGrALNyqyDsTP4bNorxkAB0y/[email protected]> Branch: refs/heads/kohana_3 Home: https://github.com/gallery/gallery3 Commit: 5460d64bd47721e688b1c13b5804ac004eb3ad77 https://github.com/gallery/gallery3/commit/5460d64bd47721e688b1c13b5804ac004eb3ad77 Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M modules/gallery/classes/Gallery/Item.php Log Message: ----------- Remove unused Item::move(). To move an item, just change its parent_id and let Model_Item and the item_moved event do the dirty work. The only place I found that references this function is the defunkt gwtorganize contrib module, so it seems safe to go. Commit: bafd47c3ec3e264fe078365c9d72d9df82b8068b https://github.com/gallery/gallery3/commit/bafd47c3ec3e264fe078365c9d72d9df82b8068b Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M modules/search/classes/Search/Controller/Search.php M modules/search/classes/Search/Search.php Log Message: ----------- Rename Search::search_query_base() --> Search::get_search_query(). Commit: 8162e8f3bc6bf518621ef94db8114fd6e6fa5345 https://github.com/gallery/gallery3/commit/8162e8f3bc6bf518621ef94db8114fd6e6fa5345 Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M modules/g2_import/classes/G2Import/Controller/G2.php M modules/gallery/classes/Gallery/Controller/Items.php M modules/gallery/classes/Gallery/Item.php M modules/gallery/classes/Gallery/View/Gallery.php M modules/image_block/classes/ImageBlock/Controller/ImageBlock.php M modules/search/classes/Search/Controller/Search.php M modules/search/classes/Search/Search.php M modules/tag/classes/Tag/Controller/Tags.php Log Message: ----------- Rename Item::set_display_context_callback() --> Item::set_display_context() and Item::clear_display_context_callback() --> Item::clear_display_context(), which match Item::get_display_context(). Commit: 360dd7d07d53b5003c60460fd02fce5dd88c75e0 https://github.com/gallery/gallery3/commit/360dd7d07d53b5003c60460fd02fce5dd88c75e0 Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M modules/user/classes/User/Group.php M modules/user/classes/User/User.php Log Message: ----------- Add @todo notes to User and Group classes - not sure if these errors still exist Commit: 60908dcaedd46456f47fb8c583025605f7f14370 https://github.com/gallery/gallery3/commit/60908dcaedd46456f47fb8c583025605f7f14370 Author: shadlaws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M modules/comment/classes/Comment/Controller/Admin/ManageComments.php M modules/gallery/classes/Gallery/Breadcrumb.php M modules/gallery/classes/Gallery/Controller/Items.php M modules/gallery/classes/Gallery/Item.php M modules/gallery/classes/Gallery/View/Gallery.php M modules/gallery/classes/Gallery/View/Theme.php M modules/search/classes/Search/Controller/Search.php M modules/search/classes/Search/Search.php M modules/tag/classes/Tag/Controller/Tags.php M modules/tag/classes/Tag/Tag.php M modules/user/classes/User/Controller/Admin/Users.php Log Message: ----------- Big rewrite of item/collection views (display context, siblings, position, breadcrumbs, pagination, etc.) - strip down Item::get_display_context() to just get context from cache. - revise View_Gallery::init_collection() to use callbacks for the collection query and breadcrumbs and to set the *same* callbacks as the item display context. This simplifies a lot of things... - add View_Gallery::init_item(), analogous to View_Gallery::init_collection(), which uses the display context and sets all sibling/position/pagination info. - revise View_Theme::siblings() to match. - strip down Breadcrumb::array_from_item_parents(). - add Breadcrumb::set_first_and_last(). - revise item collections (album, tag, search) to use new setup. Among other things, this removes a lot of position/sibling/display_context functions. - revise non-item collections (users, comments) to use the new setup. - revise the search breadcrumbs to include the "show" parameter as well as have a more descriptive title (i.e. make it similar to the tag breadcrumbs). Commit: a9f3cffd4cec1e1d592508a2fa457b651e06d20c https://github.com/gallery/gallery3/commit/a9f3cffd4cec1e1d592508a2fa457b651e06d20c Author: Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> Date: 2013-07-11 (Thu, 11 Jul 2013) Changed paths: M modules/comment/classes/Comment/Controller/Admin/ManageComments.php M modules/g2_import/classes/G2Import/Controller/G2.php M modules/gallery/classes/Gallery/Breadcrumb.php M modules/gallery/classes/Gallery/Controller/Items.php M modules/gallery/classes/Gallery/Item.php M modules/gallery/classes/Gallery/View/Gallery.php M modules/gallery/classes/Gallery/View/Theme.php M modules/image_block/classes/ImageBlock/Controller/ImageBlock.php M modules/search/classes/Search/Controller/Search.php M modules/search/classes/Search/Search.php M modules/tag/classes/Tag/Controller/Tags.php M modules/tag/classes/Tag/Tag.php M modules/user/classes/User/Controller/Admin/Users.php M modules/user/classes/User/Group.php M modules/user/classes/User/User.php Log Message: ----------- Merge pull request #454 from shadlaws/fixes_20130711 Fixes 20130711 Compare: https://github.com/gallery/gallery3/compare/aa0ce723e7f1...a9f3cffd4cec ----==_mimepart_51decc06661a8_4d6d695dd4797b Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk ----==_mimepart_51decc06661a8_4d6d695dd4797b Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline __[ g a l l e r y - c h e c k i n s ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ] ----==_mimepart_51decc06661a8_4d6d695dd4797b--