Re: Still amuck
Bharat Mediratta <[email protected]>
| Newsgroups | gmane.comp.web.gallery.devel |
|---|---|
| Message-ID | <CAESa+_mEo6vLZJ+v0xcaKRVX_O8JY68tghsSK=CK8DH8kKc-4A@mail.gmail.com> |
Ok, I found the bug and have my hands around its neck. Basically, the problem is that the Drupal<->Gallery2 module is loading up 220k+ rows into memory when it only cares about 9 of the rows, pushing PHP over the memory limit. This was breaking spam blocking and user registration. I rewrote a chunk of that code - now it's much faster. Let me know if the problem persists (or if my fix causes new problems!) -Bharat On Wed, Feb 22, 2012 at 4:32 AM, Wayne Patterson <[email protected]>wrote: > Still getting the blank screen of death > http://gallery.menalto.com/gmc_spamfight/block/361476 > > > On Tue, Feb 21, 2012 at 7:50 PM, Bharat Mediratta <[email protected]>wrote: > >> >> I have a smoking gun from the error log: >> >> [Sun Feb 19 13:49:55 2012] [error] [client 125.24.214.221] PHP Fatal >> error: Allowed memory size of 536870912 bytes exhausted (tried to allocate >> 32 bytes) in /usr/www/website/ >> gallery.menalto.com/gallery2/modules/core/classes/GalleryStorage.classon line 1376, referer: >> http://gallery.menalto.com/user//register >> >> Looks like it's the G2 integration that's the problem. I set the memory >> limit back down to 256M (which is still unreasonably high) deleted the G2 >> cache and deleted all the accumulated spam comments. Let's see if the >> problem recurs. >> >> -Bharat >> >> On Tue, Feb 21, 2012 at 11:22 AM, Donald Webster <[email protected]>wrote: >> >>> Yeah, for sure all I've done is "patch" it so that it works. Also, >>> oops I didn't realize I forgot to reply all. >>> >>> AIM: fryfrog >>> WWW: http://www.fryfrog.com >>> >>> >>> >>> On Tue, Feb 21, 2012 at 11:14 AM, Wayne Patterson >>> <[email protected]> wrote: >>> > Argh! the last one was the one from yesterday and is already blocked. >>> > I usually catch a few in the AM but occasionally one or two during the >>> day. >>> > Dave and Kevin should also report their experiences as well. >>> > >>> > My method is to right-click->save ban url->report to mollom->back to >>> ban url >>> > for blocking >>> > but the actual comments are already removed by mollom at this point so >>> there >>> > it would be just a user block. >>> > >>> > All of this worked normally a few days ago, there is some other >>> underlying >>> > issue. >>> > >>> > >>> > >>> > On Tue, Feb 21, 2012 at 12:39 PM, Donald Webster <[email protected]> >>> wrote: >>> >> >>> >> I dropped the limit to 1024M and was able to block the first two. Down >>> >> to 768M and blocked the second two. Can you give the last one a full >>> >> block and make sure it works from you? >>> >> >>> >> Someone all codey should still take a look at why this is using so >>> >> damn much memory. >>> >> >>> >> AIM: fryfrog >>> >> WWW: http://www.fryfrog.com >>> >> >>> >> >>> >> >>> >> On Tue, Feb 21, 2012 at 10:13 AM, Wayne Patterson >>> >> <[email protected]> wrote: >>> >> > http://gallery.menalto.com/gmc_spamfight/block/361547 >>> >> > http://gallery.menalto.com/gmc_spamfight/block/359627 >>> >> > http://gallery.menalto.com/gmc_spamfight/block/361534 >>> >> > http://gallery.menalto.com/gmc_spamfight/block/358049 >>> >> > http://gallery.menalto.com/gmc_spamfight/block/361307 >>> >> > >>> >> > >>> >> > On Tue, Feb 21, 2012 at 11:18 AM, Donald Webster <[email protected] >>> > >>> >> > wrote: >>> >> >> >>> >> >> bharat: I've bumped the php memory limit from 512 -> 2048 which is >>> >> >> completely insane... but it has alleviated the issue. >>> >> >> >>> >> >> Does anyone have any more examples of uses that need to be banned? >>> I'd >>> >> >> like to drop the memory limit down to something half as insane, >>> but am >>> >> >> not sure how to test w/o banning a bunch of users. >>> >> >> >>> >> >> AIM: fryfrog >>> >> >> WWW: http://www.fryfrog.com >>> >> >> >>> >> >> >>> >> >> >>> >> >> On Tue, Feb 21, 2012 at 9:15 AM, Donald Webster <[email protected] >>> > >>> >> >> wrote: >>> >> >> > Still the same error, using too much memory. >>> >> >> > >>> >> >> > [Tue Feb 21 08:52:06 2012] [error] [client 94.60.175.198] PHP >>> Fatal >>> >> >> > error: Allowed memory size of 536870912 bytes exhausted (tried >>> to >>> >> >> > allocate 82 bytes) in >>> >> >> > >>> >> >> > >>> >> >> > /usr/www/website/ >>> gallery.menalto.com/gallery2/modules/core/classes/GalleryEmbed.class >>> >> >> > on line 899, referer: http://gallery.menalto.com/user/register >>> >> >> > >>> >> >> > >>> >> >> > AIM: fryfrog >>> >> >> > WWW: http://www.fryfrog.com >>> >> >> > >>> >> >> > >>> >> >> > >>> >> >> > On Tue, Feb 21, 2012 at 8:07 AM, Wayne Patterson >>> >> >> > <[email protected]> wrote: >>> >> >> >> This morning I'm still unable to block spammers. >>> >> >> >> I'm keeping a list for when the ability is available again. >>> >> >> >> >>> >> >> >> But a new user is reporting a new issue related to user accounts >>> >> >> >> http://gallery.menalto.com/node/105425 >>> >> >> >> >>> >> >> >> >>> >> >> >> >>> >> >> >> >>> >> >> >> >>> >> >> >> >>> ------------------------------------------------------------------------------ >>> >> >> >> Keep Your Developer Skills Current with LearnDevNow! >>> >> >> >> The most comprehensive online learning library for Microsoft >>> >> >> >> developers >>> >> >> >> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, >>> CSS3, >>> >> >> >> MVC3, >>> >> >> >> Metro Style Apps, more. Free future releases when you subscribe >>> now! >>> >> >> >> http://p.sf.net/sfu/learndevnow-d2d >>> >> >> >> __[ g a l l e r y - d e v e l ]_________________________ >>> >> >> >> >>> >> >> >> [ list info/archive --> http://gallery.sf.net/lists.php ] >>> >> >> >> [ gallery info/FAQ/download --> http://gallery.sf.net ] >>> >> > >>> >> > >>> > >>> > >>> >>> >> > ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]