Re: Recent changes broke some tests

Follow-up: I've fixed all the broken tests, there were only a couple.


On Thu, Jan 17, 2013 at 12:07 PM, Bharat Mediratta <[email protected]>wrote:

> (cc gallery-devel to get more eyes involved)
>
> Hey Shad.  First of all, let me just say a big thanks for your recent code
> contributions to G3.  We've recently had a dearth of competent engineers
> who are able to make core contributions and yours have been high quality.
>
> In reviewing the recent pull request:
> https://github.com/gallery/gallery3/pull/91/files
>
> I realized that this change really needs some unit tests to verify that
> we're not breaking existing behavior.  I realize with previous pulls I've
> been lax about making sure that our tests are up to snuff and passing.
>
> In running the tests, I found some failures with the recent changes.
>  Specifically in
> https://github.com/gallery/gallery3/commit/94b26e506c339f50b8d094057bffc1877a79afa9the change to photo::get_file_metadata causes
> Item_Model_Test::unsafe_data_file_replacement_test to fail because the new
> legal_file::get_photos_by_extension doesn't know what to do with an unknown
> extension type.  The test injects "php" and expects that to fail since it's
> an unexpected extension type.
>
> I tweaked the legal_file code to be more robust
> in d04080c7be7c8a06bd81a9747943600812339f40 - but before we proceed I think
> it's probably worthwhile to add some new tests to Legal_File_Test to cover
> edge cases in the new functions you added.  Can you do that?
>
> In the meantime I'm to run all the other tests and make sure we're clean
> before going back to the pull requests.
>
> -Bharat
>

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122712

__[ g a l l e r y - d e v e l ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]