Re: jquery.autocomplete.js

Hey Dave,

Ah, good catch!  Your understanding is exactly correct, and the
references should go.  Created ticket:
https://sourceforge.net/apps/trac/gallery/ticket/2048

... and the corresponding pull in Github:
https://github.com/gallery/gallery3/pull/200

Seems like just yesterday we hit pull #100 and now we're already at #200... :-)

Take care,
Shad


On 10 March 2013 18:58, Dave Moore <[email protected]> wrote:
> Thanks for the explanation Shad.
> I'm a bit confused as well as a few users that are using GIT or just using a
> recent experimental version.
> The g2import, server_add and tag modules still have calls to combine the
> original JS & CSS files.
> Doing an upgrade to an experimental version causes the logs to be filled
> with
> error: Can't find css file: jquery.autocomplete.css
> error: Can't find script file: jquery.autocomplete.js
>
> Does that mean that the underlying code has been updated to use the new
> gallery.autocomplete function in gallery.common.js is used but the code in
> the helpers, for example:
>
>   static function head($theme) {
>     return $theme->css("jquery.autocomplete.css")
>       . $theme->script("jquery.autocomplete.js")
>       . $theme->css("tag.css");
>   }
>
> are not needed anymore or will there be future commits to remove those
> return calls?
>
> Cheers!
> Dave
>
>
>
>   On 2013-03-07 3:35 AM, Shad Laws wrote:
>
> Hi Dave,
>
> Sometime between jQuery 1.3 and 1.9, the previously-external
> autocomplete library became a part of jQuery-UI.  So, we in turn
> followed suit: for the 3.1.x branch, autocomplete is no longer a
> separate file.  Note that the 3.0.x branch, which still uses jQuery
> 1.3, still has the separate library and is therefore unaffected.
>
> The script-combining API of Gallery is relatively gentle, so if an
> external module calls for a nonexistent library, it'll just add an
> error to the log and keep going.  So that part is not a big issue.
>
> The slightly bigger issue, however, is that from the old library to
> the new one, the API changed.  The gallery.autocomplete function in
> gallery.common.js has been updated to reflect this, as have the
> autocomplete instances in the core modules (g2_import, server_add,
> tag), but no contrib modules have been tackled yet.
>
> I wouldn't worry about getting contrib modules ready for 3.1.x yet
> since we have another big change coming down the road: Kohana 3.
> Since 3.1.x will also include Kohana 3 instead of Kohana 2, we expect
> that a *lot* of contrib modules will need non-backward-compatible
> changes, and in fact will have a separate contrib repo for them.
>
> Take care,
> Shad
>
>
> On 7 March 2013 03:30, Dave Moore <[email protected]> wrote:
>
> Do you know what happened to jquery.autocomplete.js and
> jquery.autocomplete.css?
> I tried to look for the file in Git but I can see it and some modules use it
> and it use to be in the lib directory.  I can't find a commit that removed
> those files.
>
> Dave
>
>
>

------------------------------------------------------------------------------
Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester  
Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the  
endpoint security space. For insight on selecting the right partner to 
tackle endpoint security challenges, access the full report. 
http://p.sf.net/sfu/symantec-dev2dev
__[ g a l l e r y - d e v e l ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]