Re: K3 update effects on DB
Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> Wed, 3 Apr 2013 15:31:22 +0200
| Newsgroups | gmane.comp.web.gallery.devel |
|---|---|
| Message-ID | <CA+z51A4oOm71xrwMar-qp2=13_G1c1pPi3PJJA6BrSpCnnyfCA@mail.gmail.com> |
Ah, gotcha! Okay, it can be done one of two ways: 1. Add Hook_SquareThumbsEvent::graphics_crop_to_square(), then add a graphics rule for "crop_to_square" Or, if we take my suggestion and add crop to the rotate/resize/composite built-in functions... 2. Just add a graphics rule for "crop" with the right parameters. Does that seem reasonable? Take care, Shad On 2 April 2013 22:30, Bharat Mediratta <[email protected]> wrote: > > Wait, I'm still confused! Let me try again: > > The square_thumbs contrib module (which I use in production.. woot!) > defines square_thumbs_graphics::crop_to_square. In which class would that > function live in our brave new world? > > > > > On Tue, Apr 2, 2013 at 12:54 PM, Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> wrote: >> >> Hey Bharat, >> >> Ah, I see what you mean! For the moment, my intention was to leave >> the existing graphics rules system in place. The only difference was >> that the "method" part wouldn't have a class in it (e.g. >> "gallery_graphics::resize" --> "resize"). How they are added, >> deleted, and modified wouldn't change otherwise. >> >> As a separate project, we could bring these into the UI as you >> suggested, perhaps in the advanced settings dialog. >> >> Does this seem reasonable? >> >> Take care, >> Shad >> >> On 2 April 2013 20:18, Bharat Mediratta <[email protected]> wrote: >> > >> > Ah, let me clarify. I meant, what are you going to call the class in >> > the >> > watermarks module which adds the composite rule? Would it be >> > modules/watermark/classes/WatermarkGraphicsOperation? >> > >> > On Tue, Apr 2, 2013 at 9:29 AM, Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> wrote: >> >> >> >> Hey Bharat, >> >> >> >> Cool! Although I'm not sure I follow your question... doesn't >> >> Graphics::add_rule() already do this? >> >> >> >> Take care, >> >> Shad >> >> >> >> >> >> On 2 April 2013 01:08, Bharat Mediratta <[email protected]> wrote: >> >> > >> >> > Took me a few re-reads, but I like it. Make it so! My only question >> >> > is: >> >> > what is the name of the graphics operation class in modules that add >> >> > new >> >> > rules? >> >> > >> > >> > >> > ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ]