Re: Formo self::->static:: change broke tests

Bharat Mediratta <[email protected]> Wed, 15 May 2013 23:04:41 -0700
Newsgroups gmane.comp.web.gallery.devel
Message-ID <CAESa+_k38w2Vb60pCW7VcAUoazOmzCGaTmnWq_gH7xE44qzhmQ@mail.gmail.com>
--===============8893005733514298520==
Content-Type: multipart/alternative; boundary=14dae9d70fb8e38d8004dccfa6c0

--14dae9d70fb8e38d8004dccfa6c0
Content-Type: text/plain; charset=ISO-8859-1

Ah, it looks like you tweaked modules/formo unintentionally (at least, I
don't see that change in vendor).  I reverted just the modules/formo part
in a2f41e5e3d3ef53bf9b77c5b9652e3bfff0d8ce6 and now the tests don't crash.
 They don't entirely pass, but they run at least :-)


On Wed, May 15, 2013 at 6:18 PM, Bharat Mediratta <[email protected]>wrote:

>
> Shad, your recent changes broke some tests.  I don't have time to dig now
> - can you look into it?
>
>
>
> $ phpunit index.php test
>
> PHPUnit 3.6.10 by Sebastian Bergmann.
>
> .....................EEEEEE.............F......................  63 / 346
> ( 18%)
> ......EEEEEEEEE...F....."static::" is not allowed in compile-time constants
>
> /home/bharat/public_html/gallery3/modules/formo/classes/Formo/Core/Innards.php:137
> #0 [internal function]: Kohana_Core::shutdown_handler()
> #1 {main}
>

--14dae9d70fb8e38d8004dccfa6c0
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div style>Ah, it looks like you tweaked modules/formo=
 unintentionally (at least, I don&#39;t see that change in vendor). =A0I re=
verted just the modules/formo part in=A0a2f41e5e3d3ef53bf9b77c5b9652e3bfff0=
d8ce6 and now the tests don&#39;t crash. =A0They don&#39;t entirely pass, b=
ut they run at least :-)</div>

</div><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Wed,=
 May 15, 2013 at 6:18 PM, Bharat Mediratta <span dir=3D"ltr">&lt;<a href=3D=
"mailto:[email protected]" target=3D"_blank">[email protected]</a>&gt;</s=
pan> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div dir=3D"ltr"><div><br></div><div>Shad, y=
our recent changes broke some tests. =A0I don&#39;t have time to dig now - =
can you look into it?</div>

<div><br></div><div><br></div><div><br></div><div>
<font face=3D"courier new, monospace">$ phpunit index.php test</font></div>=
<div><font face=3D"courier new, monospace"><br></font></div><div><font face=
=3D"courier new, monospace">PHPUnit 3.6.10 by Sebastian Bergmann.</font></d=
iv>


<div><font face=3D"courier new, monospace"><br></font></div><div><font face=
=3D"courier new, monospace">.....................EEEEEE.............F......=
................ =A063 / 346 ( 18%)</font></div><div><font face=3D"courier =
new, monospace">......EEEEEEEEE...F.....&quot;static::&quot; is not allowed=
 in compile-time constants</font></div>


<div><font face=3D"courier new, monospace">/home/bharat/public_html/gallery=
3/modules/formo/classes/Formo/Core/Innards.php:137</font></div><div><font f=
ace=3D"courier new, monospace">#0 [internal function]: Kohana_Core::shutdow=
n_handler()</font></div>


<div><font face=3D"courier new, monospace">#1 {main}</font></div></div>
</blockquote></div><br></div>

--14dae9d70fb8e38d8004dccfa6c0--


--===============8893005733514298520==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d
--===============8893005733514298520==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

__[ g a l l e r y - d e v e l ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]
--===============8893005733514298520==--