Re: Changes to tag and rest controllers
Bharat Mediratta <[email protected]> Fri, 17 May 2013 08:06:53 -0700
| Newsgroups | gmane.comp.web.gallery.devel |
|---|---|
| Message-ID | <CAESa+_nev2TVZaqh=et5y8qM0FA2tU_Keb4zcBPa96AcXsAxrA@mail.gmail.com> |
--===============2044263816349263258== Content-Type: multipart/alternative; boundary=089e0111bdd6accc6c04dceb57ca --089e0111bdd6accc6c04dceb57ca Content-Type: text/plain; charset=ISO-8859-1 I'd prefer to have a simpler rule of "no numeric tag slugs" because that way we'll have consistent behavior in all cases. I like simple rules :-) On Fri, May 17, 2013 at 7:55 AM, Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected]> wrote: > Yah, that's easy enough to keep. Just as you said, the only slight > wrinkle is numeric tag names, but even then we don't need to *enforce* that > slugs are non-numeric. Rather, we just can't forward old URLs that > coincide with new URLs of numeric tags. > > For example: > gallery30x/tag/123 --> tag id 123. > gallery31x/tag/123 --> tag name 123, or if none exists, look for a tag id > 123 and 301 redirect. > > Take care, > Shad > > > On 17 May 2013 16:42, Bharat Mediratta <[email protected]> wrote: > >> >> Keeping around support for tag/<id> shouldn't be too hard, right? It >> just means that the user-defined slug can't be purely numeric to avoid >> conflicts. >> >> >> On Fri, May 17, 2013 at 6:34 AM, Dave Moore <[email protected]> wrote: >> >>> On 2013-05-15 8:29 PM, Bharat wrote: >>> > The tag/<id>/<name> approach was essentially a fix because originally >>> > we did tag/<name> but that was causing problems when we tried to map a >>> > slugified tag name in the url back into a tag in the database. >>> That has been some concern for me and for others as well. I would be >>> nice if we could get to: /tag/<name> without the <id> in the url. If >>> that could be sorted out then that would make some/lots users/me happy. >>> I don't know about backwards compatibility with tag/<id>/<name> is >>> required or not. I guess it depends on the amount of work required. I >>> guess it would be good or if some workaround in the .htaccess could be >>> provided as a fix, that would work as well. >>> >>> Dave >>> >>> >>> ------------------------------------------------------------------------------ >>> AlienVault Unified Security Management (USM) platform delivers complete >>> security visibility with the essential security capabilities. Easily and >>> efficiently configure, manage, and operate all of your security controls >>> from a single console and one unified framework. Download a free trial. >>> http://p.sf.net/sfu/alienvault_d2d >>> __[ g a l l e r y - d e v e l ]_________________________ >>> >>> [ list info/archive --> http://gallery.sf.net/lists.php ] >>> [ gallery info/FAQ/download --> http://gallery.sf.net ] >>> >>> >> >> >> ------------------------------------------------------------------------------ >> AlienVault Unified Security Management (USM) platform delivers complete >> security visibility with the essential security capabilities. Easily and >> efficiently configure, manage, and operate all of your security controls >> from a single console and one unified framework. Download a free trial. >> http://p.sf.net/sfu/alienvault_d2d >> __[ g a l l e r y - d e v e l ]_________________________ >> >> [ list info/archive --> http://gallery.sf.net/lists.php ] >> [ gallery info/FAQ/download --> http://gallery.sf.net ] >> > > --089e0111bdd6accc6c04dceb57ca Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><br><div style>I'd prefer to have a simpler rule of &q= uot;no numeric tag slugs" because that way we'll have consistent b= ehavior in all cases. =A0I like simple rules :-)</div></div><div class=3D"g= mail_extra"> <br><br><div class=3D"gmail_quote">On Fri, May 17, 2013 at 7:55 AM, Shad La= ws <span dir=3D"ltr"><<a href=3D"mailto:shad-xpYdmXCiSuZWk0Htik3J/[email protected]" target=3D"_bl= ank">shad-xpYdmXCiSuZWk0Htik3J/[email protected]</a>></span> wrote:<br><blockquote class=3D"gmail_= quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1= ex"> <div dir=3D"ltr">Yah, that's easy enough to keep. =A0Just as you said, = the only slight wrinkle is numeric tag names, but even then we don't ne= ed to *enforce* that slugs are non-numeric. =A0Rather, we just can't fo= rward old URLs that coincide with new URLs of numeric tags.<div> <br></div><div>For example:</div><div>gallery30x/tag/123 --> tag id 123.= </div><div>gallery31x/tag/123 --> tag name 123, or if none exists, look = for a tag id 123 and 301 redirect.</div><div><br></div> <div>Take care,</div><div>Shad</div></div><div class=3D"HOEnZb"><div class= =3D"h5"><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On 17= May 2013 16:42, Bharat Mediratta <span dir=3D"ltr"><<a href=3D"mailto:b= [email protected]" target=3D"_blank">[email protected]</a>></span> wrot= e:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"><div dir=3D"ltr"><br><div>Keeping around sup= port for tag/<id> shouldn't be too hard, right? =A0It just means = that the user-defined slug can't be purely numeric to avoid conflicts.<= /div> </div><div class=3D"gmail_extra"> <br><br><div class=3D"gmail_quote">On Fri, May 17, 2013 at 6:34 AM, Dave Mo= ore <span dir=3D"ltr"><<a href=3D"mailto:[email protected]" target=3D"= _blank">[email protected]</a>></span> wrote:<br><blockquote class=3D"g= mail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-l= eft:1ex"> <div>On 2013-05-15 8:29 PM, Bharat wrote:<br> > =A0The tag/<id>/<name> approach was essentially a fix beca= use originally<br> > we did tag/<name> but that was causing problems when we tried to= map a<br> > slugified tag name in the url back into a tag in the database.<br> </div>That has been some concern for me and for others as well. =A0I would = be<br> nice if we could get to: /tag/<name> without the <id> in the ur= l. =A0If<br> that could be sorted out then that would make some/lots users/me happy.<br> I don't know about backwards compatibility with tag/<id>/<name= > is<br> required or not. I guess it depends on the amount of work required. =A0I<br= > guess it would be good or if some workaround in the .htaccess could be<br> provided as a fix, that would work as well.<br> <span><font color=3D"#888888"><br> Dave<br> </font></span><div><div><br> ---------------------------------------------------------------------------= ---<br> AlienVault Unified Security Management (USM) platform delivers complete<br> security visibility with the essential security capabilities. Easily and<br= > efficiently configure, manage, and operate all of your security controls<br= > from a single console and one unified framework. Download a free trial.<br> <a href=3D"http://p.sf.net/sfu/alienvault_d2d" target=3D"_blank">http://p.s= f.net/sfu/alienvault_d2d</a><br> __[ g a l l e r y - d e v e l ]_________________________<br> <br> [ list info/archive --> <a href=3D"http://gallery.sf.net/lists.php" targ= et=3D"_blank">http://gallery.sf.net/lists.php</a> ]<br> [ gallery info/FAQ/download --> <a href=3D"http://gallery.sf.net" target= =3D"_blank">http://gallery.sf.net</a> ]<br> <br> </div></div></blockquote></div><br></div> <br>-----------------------------------------------------------------------= -------<br> AlienVault Unified Security Management (USM) platform delivers complete<br> security visibility with the essential security capabilities. Easily and<br= > efficiently configure, manage, and operate all of your security controls<br= > from a single console and one unified framework. Download a free trial.<br> <a href=3D"http://p.sf.net/sfu/alienvault_d2d" target=3D"_blank">http://p.s= f.net/sfu/alienvault_d2d</a><br>__[ g a l l e r y - d e v e l ]____________= _____________<br> <br> [ list info/archive --> <a href=3D"http://gallery.sf.net/lists.php" targ= et=3D"_blank">http://gallery.sf.net/lists.php</a> ]<br> [ gallery info/FAQ/download --> <a href=3D"http://gallery.sf.net" target= =3D"_blank">http://gallery.sf.net</a> ]<br></blockquote></div><br></div> </div></div></blockquote></div><br></div> --089e0111bdd6accc6c04dceb57ca-- --===============2044263816349263258== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d --===============2044263816349263258== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ] --===============2044263816349263258==--