Re: Changes to tag and rest controllers
Dave Moore <[email protected]> Sun, 19 May 2013 10:45:46 -0600
| Newsgroups | gmane.comp.web.gallery.devel |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --===============5341723724228029436== Content-Type: multipart/alternative; boundary="------------010405090308000604000903" This is a multi-part message in MIME format. --------------010405090308000604000903 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Just a fyi that you can kill a couple of tickets and I'm sure there is a few more requests in the forums: http://galleryproject.org/node/100026 http://sourceforge.net/apps/trac/gallery/ticket/333 http://sourceforge.net/apps/trac/gallery/ticket/1152 and a bit more complex: http://sourceforge.net/apps/trac/gallery/ticket/1326 I like the idea of finding multi tags as a first enhancement. Dave On 2013-05-17 10:39 AM, Shad Laws wrote: > Hmm... good question. > > My first inclination isn't to make a hierarchy, but rather an extra > cross-reference. For example, "gallery/tag/me/you" would find photos > tagged with both me and you. Thoughts? > > Take care, > Shad > > > On 17 May 2013 17:56, Chad Kieffer <[email protected] > <mailto:[email protected]>> wrote: > > Although tags are strictly flat now, how might hierarchical > structures be routed in the future? I think even if support for > taxonomies isn't part of G3 now, it might be worth considering as > part of this discussion. > > - Chad > > On May 17, 2013, at 9:15 AM, Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected] > <mailto:shad-xpYdmXCiSuZWk0Htik3J/[email protected]>> wrote: > >> Hmm... I'm not sure I agree. For example, this would make folks >> with photos about 90210, 356, and 1776 really annoyed at the new >> system. The simplest rule is the one we don't need :-) >> >> My preference is this: >> - make the new system simple, flexible, and exactly what we want. >> - provide enough redirects for old URLs to keep most old sites >> happy during the conversion. >> >> Thinking again, there's actually a better rule we can use to deal >> with old redirects: >> gallery30x/tag/123/321 --> tag id 123 (which coincidentally has >> name 321, but this isn't checked) - old canonical URL >> gallery31x/tag/123/321 --> tag id 123, name 321 (sees slash and >> tries this), then 301 redirect. >> gallery31x/tag/123 --> tag name 123, or if none exists, look for >> a tag id 123 and 301 redirect. >> gallery31x/tag/321 --> tag name 321 (which coincidentally has id >> 123, but this isn't checked) - new canonical URL >> >> The only oddball case here is old URLs that were truncated *and* >> coincide with new URLs, for which I don't think we should break >> our new system to support... >> >> Take care, >> Shad >> >> >> >> On 17 May 2013 17:06, Bharat Mediratta <[email protected] >> <mailto:[email protected]>> wrote: >> >> >> I'd prefer to have a simpler rule of "no numeric tag slugs" >> because that way we'll have consistent behavior in all cases. >> I like simple rules :-) >> >> >> On Fri, May 17, 2013 at 7:55 AM, Shad Laws <shad-xpYdmXCiSuZWk0Htik3J/[email protected] >> <mailto:shad-xpYdmXCiSuZWk0Htik3J/[email protected]>> wrote: >> >> Yah, that's easy enough to keep. Just as you said, the >> only slight wrinkle is numeric tag names, but even then >> we don't need to *enforce* that slugs are non-numeric. >> Rather, we just can't forward old URLs that coincide >> with new URLs of numeric tags. >> >> For example: >> gallery30x/tag/123 --> tag id 123. >> gallery31x/tag/123 --> tag name 123, or if none exists, >> look for a tag id 123 and 301 redirect. >> >> Take care, >> Shad >> >> >> On 17 May 2013 16:42, Bharat Mediratta >> <[email protected] <mailto:[email protected]>> wrote: >> >> >> Keeping around support for tag/<id> shouldn't be too >> hard, right? It just means that the user-defined >> slug can't be purely numeric to avoid conflicts. >> >> >> On Fri, May 17, 2013 at 6:34 AM, Dave Moore >> <[email protected] <mailto:[email protected]>> wrote: >> >> On 2013-05-15 8:29 PM, Bharat wrote: >> > The tag/<id>/<name> approach was essentially a >> fix because originally >> > we did tag/<name> but that was causing problems >> when we tried to map a >> > slugified tag name in the url back into a tag >> in the database. >> That has been some concern for me and for others >> as well. I would be >> nice if we could get to: /tag/<name> without the >> <id> in the url. If >> that could be sorted out then that would make >> some/lots users/me happy. >> I don't know about backwards compatibility with >> tag/<id>/<name> is >> required or not. I guess it depends on the amount >> of work required. I >> guess it would be good or if some workaround in >> the .htaccess could be >> provided as a fix, that would work as well. >> >> Dave >> >> ------------------------------------------------------------------------------ >> AlienVault Unified Security Management (USM) >> platform delivers complete >> security visibility with the essential security >> capabilities. Easily and >> efficiently configure, manage, and operate all of >> your security controls >> from a single console and one unified framework. >> Download a free trial. >> http://p.sf.net/sfu/alienvault_d2d >> __[ g a l l e r y - d e v e l >> ]_________________________ >> >> [ list info/archive --> >> http://gallery.sf.net/lists.php ] >> [ gallery info/FAQ/download --> >> http://gallery.sf.net ] >> >> >> >> ------------------------------------------------------------------------------ >> AlienVault Unified Security Management (USM) platform >> delivers complete >> security visibility with the essential security >> capabilities. Easily and >> efficiently configure, manage, and operate all of >> your security controls >> from a single console and one unified framework. >> Download a free trial. >> http://p.sf.net/sfu/alienvault_d2d >> __[ g a l l e r y - d e v e l ]_________________________ >> >> [ list info/archive --> http://gallery.sf.net/lists.php ] >> [ gallery info/FAQ/download --> http://gallery.sf.net ] >> >> >> >> >> ------------------------------------------------------------------------------ >> AlienVault Unified Security Management (USM) platform delivers >> complete >> security visibility with the essential security capabilities. >> Easily and >> efficiently configure, manage, and operate all of your security >> controls >> from a single console and one unified framework. Download a free >> trial. >> http://p.sf.net/sfu/alienvault_d2d >> __[ g a l l e r y - d e v e l ]_________________________ >> >> [ list info/archive --> http://gallery.sf.net/lists.php ] >> [ gallery info/FAQ/download --> http://gallery.sf.net ] > > --------------010405090308000604000903 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">Just a fyi that you can kill a couple of tickets and I'm sure there is a few more requests in the forums:<br> <a class="moz-txt-link-freetext" href="http://galleryproject.org/node/100026">http://galleryproject.org/node/100026</a><br> <a class="moz-txt-link-freetext" href="http://sourceforge.net/apps/trac/gallery/ticket/333">http://sourceforge.net/apps/trac/gallery/ticket/333</a><br> <a class="moz-txt-link-freetext" href="http://sourceforge.net/apps/trac/gallery/ticket/1152">http://sourceforge.net/apps/trac/gallery/ticket/1152</a><br> and a bit more complex: <a class="moz-txt-link-freetext" href="http://sourceforge.net/apps/trac/gallery/ticket/1326">http://sourceforge.net/apps/trac/gallery/ticket/1326</a><br> <br> I like the idea of finding multi tags as a first enhancement.<br> <br> Dave<br> <br> On 2013-05-17 10:39 AM, Shad Laws wrote:<br> </div> <blockquote cite="mid:CA+z51A5HG+tcSEcdXikpW7YwFiUAshCQHap3wACeKOPKO1YsEA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org" type="cite"> <div dir="ltr">Hmm... good question. <div><br> </div> <div>My first inclination isn't to make a hierarchy, but rather an extra cross-reference. For example, "gallery/tag/me/you" would find photos tagged with both me and you. Thoughts? <div> <br> </div> <div>Take care,</div> <div>Shad</div> </div> </div> <div class="gmail_extra"><br> <br> <div class="gmail_quote">On 17 May 2013 17:56, Chad Kieffer <span dir="ltr"><<a moz-do-not-send="true" href="mailto:[email protected]" target="_blank">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="auto"> <div>Although tags are strictly flat now, how might hierarchical structures be routed in the future? I think even if support for taxonomies isn't part of G3 now, it might be worth considering as part of this discussion.</div> <div><br> </div> <div>- Chad</div> <div><br> On May 17, 2013, at 9:15 AM, Shad Laws <<a moz-do-not-send="true" href="mailto:shad-xpYdmXCiSuZWk0Htik3J/[email protected]" target="_blank">shad-xpYdmXCiSuZWk0Htik3J/[email protected]</a>> wrote:<br> <br> </div> <blockquote type="cite"> <div> <div dir="ltr"> Hmm... I'm not sure I agree. For example, this would make folks with photos about 90210, 356, and 1776 really annoyed at the new system. The simplest rule is the one we don't need :-) <div><br> </div> <div>My preference is this:</div> <div>- make the new system simple, flexible, and exactly what we want.</div> <div>- provide enough redirects for old URLs to keep most old sites happy during the conversion.</div> <div><br> </div> <div>Thinking again, there's actually a better rule we can use to deal with old redirects:</div> <div> <div style="font-family:arial,sans-serif;font-size:13px">gallery30x/tag/123/321 --> tag id 123 (which coincidentally has name 321, but this isn't checked) - old canonical URL</div> <div style="font-size:13px;font-family:arial,sans-serif">gallery31x/tag/123/321 --> tag id 123, name 321 (sees slash and tries this), then 301 redirect.</div> <div style="font-family:arial,sans-serif;font-size:13px">gallery31x/tag/123 --> tag name 123, or if none exists, look for a tag id 123 and 301 redirect.</div> <div style="font-family:arial,sans-serif;font-size:13px">gallery31x/tag/321 --> tag name 321 (which coincidentally has id 123, but this isn't checked) - new canonical URL</div> <div style="font-family:arial,sans-serif;font-size:13px"> <br> </div> <div style="font-family:arial,sans-serif;font-size:13px">The only oddball case here is old URLs that were truncated *and* coincide with new URLs, for which I don't think we should break our new system to support...</div> <div style="font-family:arial,sans-serif;font-size:13px"><br> </div> <div style="font-family:arial,sans-serif;font-size:13px">Take care,</div> <div style="font-family:arial,sans-serif;font-size:13px">Shad</div> <div style="font-family:arial,sans-serif;font-size:13px"> <br> </div> </div> </div> <div class="gmail_extra"><br> <br> <div class="gmail_quote">On 17 May 2013 17:06, Bharat Mediratta <span dir="ltr"><<a moz-do-not-send="true" href="mailto:[email protected]" target="_blank">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr"><br> <div>I'd prefer to have a simpler rule of "no numeric tag slugs" because that way we'll have consistent behavior in all cases. I like simple rules :-)</div> </div> <div class="gmail_extra"> <br> <br> <div class="gmail_quote">On Fri, May 17, 2013 at 7:55 AM, Shad Laws <span dir="ltr"><<a moz-do-not-send="true" href="mailto:shad-xpYdmXCiSuZWk0Htik3J/[email protected]" target="_blank">shad-xpYdmXCiSuZWk0Htik3J/[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr">Yah, that's easy enough to keep. Just as you said, the only slight wrinkle is numeric tag names, but even then we don't need to *enforce* that slugs are non-numeric. Rather, we just can't forward old URLs that coincide with new URLs of numeric tags. <div> <br> </div> <div>For example:</div> <div>gallery30x/tag/123 --> tag id 123.</div> <div>gallery31x/tag/123 --> tag name 123, or if none exists, look for a tag id 123 and 301 redirect.</div> <div><br> </div> <div>Take care,</div> <div>Shad</div> </div> <div> <div> <div class="gmail_extra"><br> <br> <div class="gmail_quote">On 17 May 2013 16:42, Bharat Mediratta <span dir="ltr"><<a moz-do-not-send="true" href="mailto:[email protected]" target="_blank">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div dir="ltr"><br> <div>Keeping around support for tag/<id> shouldn't be too hard, right? It just means that the user-defined slug can't be purely numeric to avoid conflicts.</div> </div> <div class="gmail_extra"> <br> <br> <div class="gmail_quote">On Fri, May 17, 2013 at 6:34 AM, Dave Moore <span dir="ltr"><<a moz-do-not-send="true" href="mailto:[email protected]" target="_blank">[email protected]</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div>On 2013-05-15 8:29 PM, Bharat wrote:<br> > The tag/<id>/<name> approach was essentially a fix because originally<br> > we did tag/<name> but that was causing problems when we tried to map a<br> > slugified tag name in the url back into a tag in the database.<br> </div> That has been some concern for me and for others as well. I would be<br> nice if we could get to: /tag/<name> without the <id> in the url. If<br> that could be sorted out then that would make some/lots users/me happy.<br> I don't know about backwards compatibility with tag/<id>/<name> is<br> required or not. I guess it depends on the amount of work required. I<br> guess it would be good or if some workaround in the .htaccess could be<br> provided as a fix, that would work as well.<br> <span><font color="#888888"><br> Dave<br> </font></span> <div> <div><br> ------------------------------------------------------------------------------<br> AlienVault Unified Security Management (USM) platform delivers complete<br> security visibility with the essential security capabilities. Easily and<br> efficiently configure, manage, and operate all of your security controls<br> from a single console and one unified framework. Download a free trial.<br> <a moz-do-not-send="true" href="http://p.sf.net/sfu/alienvault_d2d" target="_blank">http://p.sf.net/sfu/alienvault_d2d</a><br> __[ g a l l e r y - d e v e l ]_________________________<br> <br> [ list info/archive --> <a moz-do-not-send="true" href="http://gallery.sf.net/lists.php" target="_blank">http://gallery.sf.net/lists.php</a> ]<br> [ gallery info/FAQ/download --> <a moz-do-not-send="true" href="http://gallery.sf.net" target="_blank">http://gallery.sf.net</a> ]<br> <br> </div> </div> </blockquote> </div> <br> </div> <br> ------------------------------------------------------------------------------<br> AlienVault Unified Security Management (USM) platform delivers complete<br> security visibility with the essential security capabilities. Easily and<br> efficiently configure, manage, and operate all of your security controls<br> from a single console and one unified framework. Download a free trial.<br> <a moz-do-not-send="true" href="http://p.sf.net/sfu/alienvault_d2d" target="_blank">http://p.sf.net/sfu/alienvault_d2d</a><br> __[ g a l l e r y - d e v e l ]_________________________<br> <br> [ list info/archive --> <a moz-do-not-send="true" href="http://gallery.sf.net/lists.php" target="_blank">http://gallery.sf.net/lists.php</a> ]<br> [ gallery info/FAQ/download --> <a moz-do-not-send="true" href="http://gallery.sf.net" target="_blank">http://gallery.sf.net</a> ]<br> </blockquote> </div> <br> </div> </div> </div> </blockquote> </div> <br> </div> </blockquote> </div> <br> </div> </div> </blockquote> <blockquote type="cite"> <div><span>------------------------------------------------------------------------------</span><br> <span>AlienVault Unified Security Management (USM) platform delivers complete</span><br> <span>security visibility with the essential security capabilities. Easily and</span><br> <span>efficiently configure, manage, and operate all of your security controls</span><br> <span>from a single console and one unified framework. Download a free trial.</span><br> <span><a moz-do-not-send="true" href="http://p.sf.net/sfu/alienvault_d2d" target="_blank">http://p.sf.net/sfu/alienvault_d2d</a></span></div> </blockquote> <blockquote type="cite"> <div><span>__[ g a l l e r y - d e v e l ]_________________________</span><br> <span></span><br> <span>[ list info/archive --> <a moz-do-not-send="true" href="http://gallery.sf.net/lists.php" target="_blank">http://gallery.sf.net/lists.php</a> ]</span><br> <span>[ gallery info/FAQ/download --> <a moz-do-not-send="true" href="http://gallery.sf.net" target="_blank">http://gallery.sf.net</a> ]</span></div> </blockquote> </div> </blockquote> </div> <br> </div> </blockquote> <br> </body> </html> --------------010405090308000604000903-- --===============5341723724228029436== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d --===============5341723724228029436== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline __[ g a l l e r y - d e v e l ]_________________________ [ list info/archive --> http://gallery.sf.net/lists.php ] [ gallery info/FAQ/download --> http://gallery.sf.net ] --===============5341723724228029436==--