Re: PATCH: 3.2.0b5 config parser fixes

On Fri, 23 Apr 2004, Gilles Detillieux wrote:

> Date: Fri, 23 Apr 2004 17:43:14 -0500 (CDT)
> From: Gilles Detillieux <[email protected]>
> To: Joe R. Jah <[email protected]>
> Cc: "ht://Dig developers list" <[email protected]>
> Subject: Re: [htdig-dev] PATCH: 3.2.0b5 config parser fixes
> 
> According to Joe R. Jah:
> > I believe we should make the patches against virgin 3.2.0b5; alternatively
> > we should indicate to what snapshot they apply.  Many people do not
> > download weekly snapshots, and use the patches to upgrade 3.2.0b5.
> > I plead guilty, until a few minutes ago;)
> 
> I agree.  Certainly for the archives, it's important they they apply
> to the release they're supposedly for, and dependencies on other patches
> should be stated.  I was just trying to get the patch out quickly, after
> spending hours playing with the code, and I didn't consider these issues.
> 
> Below is an updated patch, which should apply properly to 3.2.0b5.

Thank you Guilles; this patch applies and compiles like a charm;)

> > I see that except one, the patches in the patch site have not been
> > committed to 3.2.0b5-20040418; when will they be committed?
> 
> We'll obviously need to look into this, to determine the suitability
> and reliability of each patch.  Certainly the bug fixes need to get in
> in some form or other.

[snip]

> I guess yacc doesn't support passing parameters to yyparse(), or does
> it differently.  Anyone have ideas about this?
> 
> > I also reconfigured with GNU Bison version 1.28; this is what I got:(
> 
> I was able to build earlier 3.2 betas with bison 1.28, so I'm not sure
> why there's a problem.
> 
> > sed '/^#/ s|y\.tab\.c|conf_parser.cxx|' y.tab.c >conf_parser.cxxt && mv conf_parser.cxxt conf_parser.cxx
> > sed: y.tab.c: No such file or directory
> > gmake[1]: *** [conf_parser.cxx] Error 1
> > gmake[1]: Leaving directory `/usr/tmp/htdig/htdig-3.2.0b5/htcommon'
> > gmake: *** [all-recursive] Error 1
> > 
> > Does it require a more recent version of Bison?
> 
> That's odd, as y.tab.c is the standard yacc/bison output file name.

I believe the file name it had output was conf_parser.yxx.tab.c:

ll */conf_parser*
-rwxr-xr--  1 jjah  wheel  38662 Nov  8 19:46 htcommon/conf_parser.cxx
-rw-r--r--  1 jjah  wheel      0 Apr 23 13:18 htcommon/conf_parser.cxxt
-rw-r--r--  1 jjah  wheel    330 Apr 22 21:40 htcommon/conf_parser.h
-rw-r--r--  1 jjah  wheel    240 Apr 23 13:09 htcommon/conf_parser.loT
-rwxr-xr--  1 jjah  wheel   6319 Nov  8 19:46 htcommon/conf_parser.yxx
-rw-r--r--  1 jjah  wheel  31798 Apr 23 13:18 htcommon/conf_parser.yxx.tab.c
-rw-r--r--  1 jjah  wheel    311 Apr 23 13:18 htcommon/conf_parser.yxx.tab.h

> Are there any error messages above that would help?  How did you
> reconfigure it to use bison instead of yacc?

Those stated above were the only error messages.  Here is how I
reconfigured/recompiled:

gmake distclean
YACC="/usr/local/bin/bison"
export YACC
./configure
...
gmake

Regards,

Joe
-- 
     _/   _/_/_/       _/              ____________    __o
     _/   _/   _/      _/         ______________     _-\<,_
 _/  _/   _/_/_/   _/  _/                     ......(_)/ (_)
  _/_/ oe _/   _/.  _/_/ ah        [email protected]



-------------------------------------------------------
This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek
For a limited time only, get FREE Ground shipping on all orders of $35
or more. Hurry up and shop folks, this offer expires April 30th!
http://www.thinkgeek.com/freeshipping/?cpg=12297
_______________________________________________
ht://Dig Developer mailing list:
[email protected]
List information (subscribe/unsubscribe, etc.)
https://lists.sourceforge.net/lists/listinfo/htdig-dev