Re: Meaning and use of TIDY_STORE_ORIGINAL_TEXT

* Geoff Air wrote:
>Thank you for clarifying, and giving a link, to the CVS
>tree ... but I think that 'tree' is what is updated, when
>I do my regular 'cvs up -dP' to my local tidy (cvs) folder ...
>so I have all that ... do I not? ... why would browsing
>this CVS tree online give me more?

You can use it to annoate the code to see who wrote which part of the
code, get diffs, log messages, ...

>But it seems nowhere is it documented that you were
>the author of TIDY_STORE_ORIGINAL_TEXT code, nor when it
>was included, and there appears no documentation of its
>original purpose ... but that is NOT so important now ;=))

... so all of this would be readily accessible :-)

>I have FOUND a very good DEBUG purpose, and USE IT ...
>why not 'agree' to add my small 'fixes', and allow me
>to continue to use it for this purpose? Other developers
>may also 'like' this use, now that more is documented
>about it ... and it is getting 'fixed' ...

My concern is that people would start relying on it in which case they
expect us to maintain it, and the tidy project is very low on resources
already. I am also not sure whether your changes would interfere with
how I used this code or anything else (as I didn't read the patches in
detail and don't remember all the details relative to the code); I am
not totally opposed to making the changes, but we should exercise some
care.

>Whether I, or anyone else 'finds' ANOTHER use for your
>TIDY_STORE_ORIGINAL_TEXT code remains to be seen ... but
>can I add, it is reasonably good code, and does not contain
>as many 'subtle' bugs as you, the author, seem to think ...
>you do seem to have taken into account most of the parser,
>lexer, sometimes VERY torturous, paths ;=))

(There are some users of this code, at least I get mails about it every
now and then and sometimes point people at it if they want to use Tidy
in a very special way; the functionality does have some use, but I have
zero confidence in what we have now, and not much time to review any
changes; that's why I asked others to chime in).

>I have mentioned that it does seem to 'miss' some line
>endings in certain circumstance, and I have not yet tested
>it fully with 'scripts', like <?, embedded in the HTML ...
>and especially with 'double-byte' languages ... chinese,
>hangul, kanji, etc, which links to multiple language
>support ... character encodings ... something I think is
>of growing importance ...

Yes, those spaces are a major reason for why the feature was useless to
me unless wrapped into a special parser loop that ensures all spaces are
retained.
-- 
Björn Höhrmann · mailto:[email protected] · http://bjoern.hoehrmann.de
Weinh. Str. 22 · Telefon: +49(0)621/4309674 · http://www.bjoernsworld.de
68309 Mannheim · PGP Pub. KeyID: 0xA4357E78 · http://www.websitedev.de/ 


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click