Re: A new patch, good efficiency improvements.

* Cory Nelson wrote:
>This patch roughly halved parse times and slightly decreased memory
>usage for me.
>
>It's available here:
>http://sourceforge.net/tracker/index.php?func=detail&aid=1411453&group_id=27659&atid=390965

Style nits:

  * no tabs
  * (...) always without spaces (I know Tidy doesn't do this throughout)
  * if (...) block else statement should be if (...) block else block
  * "{" always on a new line
  * if (...) foo, foo always on a new line
  * "foo=bar" should be "foo = bar"
  * lines should not be longer than ~76 columns

I am not sure about including <windows.h> in several places; wouldn't it
make more sense to include it in platform.h or similar? There seems to
be an orphaned block in initMappedFileSource.
-- 
Björn Höhrmann · mailto:[email protected] · http://bjoern.hoehrmann.de
Weinh. Str. 22 · Telefon: +49(0)621/4309674 · http://www.bjoernsworld.de
68309 Mannheim · PGP Pub. KeyID: 0xA4357E78 · http://www.websitedev.de/ 


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642