Re: Bug?

Cory Nelson <[email protected]> Wed, 25 Jan 2006 03:45:43 -0800
Newsgroups gmane.comp.web.html-tidy.devel
Message-ID <[email protected]>
On 1/25/06, Bjoern Hoehrmann <[email protected]> wrote:
> * Cory Nelson wrote:
> >IgnoreWhitespace is defined to 0, and in lexer.c line 1989 there is a
> >bitwise being done with it (mode & IgnoreWhitespace).  Bug?
>
> http://cvs.sourceforge.net/viewcvs.py/tidy/tidy/src/lexer.c?r1=1.3&r2=1.4
> Maybe Charlie knows? Major changes to whitespace processing have been
> made since, so this might just do what we want.

It will always evaluate to 0, so maybe it should be taken out if that
was intentional.

I also noticed attrs.c line 1370 - there is an expression
(node->tag->model & CM_TABLE|CM_ROW).  Bitwise AND takes precedence
over bitwise OR and the spacing suggests the author really wanted
(node->tag->model & (CM_TABLE|CM_ROW)).

> --
> Björn Höhrmann · mailto:[email protected] · http://bjoern.hoehrmann.de
> Weinh. Str. 22 · Telefon: +49(0)621/4309674 · http://www.bjoernsworld.de
> 68309 Mannheim · PGP Pub. KeyID: 0xA4357E78 · http://www.websitedev.de/
>


--
Cory Nelson
http://www.int64.org


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid3432&bid#0486&dat1642