Re: Regarding my old mmap patch
"Geoff Air" <[email protected]> Mon, 04 Sep 2006 16:26:38 +0000
| Newsgroups | gmane.comp.web.html-tidy.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Cory, Thank you again for this improved patch ... it applied cleanly to the current cvs, and on large files I got about a 25% reduction in total processing time ... This patch seems well worth adding to cvs? Of course, in MSVC7.1 you have to remember to put 'No' to Properties->C/C++->Language-> Disable Language Extensions on the files that now include <windows.h>, thus we, in WIN32, lose some of the warning about inline (//) comments ... but this is not particularly a 'bad' thing ... As you may remember, last time I did test it without the granularity management, i.e. just data->view = MapViewOfFile( data->map, FILE_MAP_READ, 0, 0, 0); and letting the OS handle the buffers, as it will, but this direct handling also shaved off a few more percent points on large files ... so it is a good addition ... I am not sure your memory-pooling patch was so 'controversial', as it also improved processing time and memory usage ... but c'est la vie ;=)) Regards, Geoff. _________________________________________________________________ Express yourself instantly with MSN Messenger! Download today it's FREE! http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/ ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642