Re: Regarding my old mmap patch

On 9/5/06, Charlie Reitzel <[email protected]> wrote:
> Hi Corey, All,
>
> First off, thanks for submitting this.  It is a great idea and it looks
> well done.
>
> I'd have to cast my vote as "no" on committing this patch for one simple
> reason.  It introduces too much platform-specific code into too many
> files.  Ideally, all platform considerations are kept in platform.h.  The
> MLANG addition was one exception to this that, imo, should be removed (as
> it was not finished).

Perhaps all this could be moved into a mmap_win32.c then?  I already
strongly dislike platform.h already because it brings in so many
includes/defines that a public API shouldn't.

> Put another way, why not use memory-mapped files on all (or at least most)
> platforms?  Unix, Linux, Windows, OS/2, and probably Mac/X, should all
> support this functionality.  So a compromise might be to wrap the Windows
> shared-memory APIs to look like Unix.

I have little experience mmapping on *nix but I do understand they are
different enough that it would probably take more code to wrap it than
to just maintain separate files with the same APIs.

> Then again, I might be out voted.
>
> take it easy,
> Charlie
>
>
>
> At 11:01 PM 9/3/2006 -0700, Cory Nelson wrote:
> >I finally got some more time and have submitted a new patch, this time
> >with the other more controversial stuff taken out, leaving only the
> >win32 memory mapping.
> >
> >The patch works off of tonight's CVS.
> >
> >http://sourceforge.net/tracker/index.php?func=detail&aid=1551769&group_id=27659&atid=390965
> >
> >--
> >Cory Nelson
> >http://www.int64.org
> >
> >-------------------------------------------------------------------------
> >Using Tomcat but need to do more? Need to support web services, security?
> >Get stuff done quickly with pre-integrated technology to make your job easier
> >Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> >http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> >_______________________________________________
> >Tidy-develop mailing list
> >[email protected]
> >https://lists.sourceforge.net/lists/listinfo/tidy-develop
>


-- 
Cory Nelson
http://www.int64.org

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642