Re: TIDY_STORE_ORIGINAL_TEXT?

Hi Chris, and Charles, ...
 
If you are monitoring the http://tidy.sf.net/issue/2811690 you should have my post to there, pointing you to my new site page :-
 http://geoffair.net/tidy/tidy_13.htm
and the patches :-
 http://geoffair.net/tidy/txt/tidystore-01.txt
 
As the site indicates, this addresses some small remaining problems enabling TIDY_STORE_ORIGINAL_TEXT, which should be fixed by the above patch. I have done some testing, but not complete or extensive... but it now seems to work fine.
 
This is in fact a great 'feature', and should perhaps be defined by default, especially since there is an enabling switch, so it nothing is done if this switch is off/no - which it should be by default... but that would also mean expanding the Tidy API to get at this data, once enabled...
 
And concerning the TAB expansion, as you sort of pointed out, there seems no reason to keep bumping in->curcol++; on each space added during a tab expansion. Removing this gets the column reporting correct if just one tab, and much closer to correct if there is more than one tab in the line... 
 
The multiple tab situation involves the rather complicated SaveLastPos(in), RestoreLastPos(in) and PopLastPos(in) set of calls...
 
Every call to TY_(ReadChar)() does a SaveLastPos(in)...
And TY_(UngetChar)() does a RestoreLastPos()
So far so good,,,
 
And when the PopChar(in) is called, it adjusts in->curcol directly, and in->curline if '\n', BUT then still calls PopLastPos(in)...
 
This seeming redundancy is what makes it complicated in the multiple tab situation... will keep looking at it, but do NOT hold your breath ;=))
 
Regards,
 
Geoff.
 
_________________________________________________________________
More than messages–check out the rest of the Windows Live™.
http://www.microsoft.com/windows/windowslive/

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge

_______________________________________________
Tidy-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tidy-develop