Re: Tidy bug
Ben McCann <[email protected]> Mon, 26 Oct 2009 18:00:54 -0700
| Newsgroups | gmane.comp.web.html-tidy.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============2920751422622768392== Content-Type: multipart/alternative; boundary=000e0cd2965ecedd370476e03598 --000e0cd2965ecedd370476e03598 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thanks a lot for the patch Klaus. Is this something that we'd be able to submit to CVS? On Wed, Oct 21, 2009 at 7:30 AM, Charlie Reitzel <[email protected]> wrote: > Looks good to me. Arnaud and Bj=F6rn, do you guys see any unwanted > side-effects of this change? > > At 02:29 PM 10/21/2009 +0200, Klaus Johannes Rusch wrote: > >Ben McCann wrote: > >>Hi Klaus, > >>I see that you > >>< > https://sourceforge.net/tracker/?func=3Ddetail&aid=3D2855621&group_id=3D2= 7659&atid=3D390963 > >marked > >>the issue I reported as rejected on SourceForge. Can we reopen it to > >>reflect the conversation on this email thread? I'd like it if we could > >>work on implementing your suggestion: "One thing I can think of that > >>would help with this example is discarding elements for which only an e= nd > >>tag is found, rather than generating a corresponding start tag." > > > >Ben, > > > >the bug report is open and I have a possible fix, I can send you the win > >binary or you can try the modification below yourself if you want to > >experiment with the patched version on another platform. > > > >Charlie, > > > >it's been a while since I touched the tidy source code (looked pretty > >unfamiliar :-)), the fix appears to resolve the specific issue and not > >cause harm with a number of table related test cases I tried, would > >appreciate if you could look over this though and let me know if you > agree: > > > >RCS file: /cvsroot/tidy/tidy/src/parser.c,v > >retrieving revision 1.187 > >diff -r1.187 parser.c > >3471,3472c3471,3475 > >< TY_(UngetToken)( doc ); > >< node =3D TY_(InferredTag)(doc, TidyTag_TABLE); > >--- > > > /* > > <http://tidy.sf.net/issue/2855621>http://tidy.sf.net/issue/2855621 */ > > > if (node->type !=3D EndTag) { > > > TY_(UngetToken)( doc ); > > > node =3D TY_(InferredTag)(doc, TidyTag_TABLE); > > > } > > > >-- > >Klaus Johannes Rusch > ><mailto:[email protected]>[email protected] > >http://www.atmedia.net/KlausRusch/ > > > > -------------------------------------------------------------------------= ----- > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > _______________________________________________ > Tidy-develop mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/tidy-develop > --000e0cd2965ecedd370476e03598 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thanks a lot for the patch Klaus.=A0 Is this something that we'd be abl= e to submit to CVS?<br><br><br><div class=3D"gmail_quote">On Wed, Oct 21, 2= 009 at 7:30 AM, Charlie Reitzel <span dir=3D"ltr"><<a href=3D"mailto:cre= [email protected]">[email protected]</a>></span> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, = 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Looks good to me.= =A0Arnaud and Bj=F6rn, do you guys see any unwanted<br> side-effects of this change?<br> <div class=3D"im"><br> At 02:29 PM 10/21/2009 +0200, Klaus Johannes Rusch wrote:<br> >Ben McCann wrote:<br> >>Hi Klaus,<br> >>I see that you<br> </div>>><<a href=3D"https://sourceforge.net/tracker/?func=3Ddetail= &aid=3D2855621&group_id=3D27659&atid=3D390963" target=3D"_blank= ">https://sourceforge.net/tracker/?func=3Ddetail&aid=3D2855621&grou= p_id=3D27659&atid=3D390963</a>>marked<br> <div class=3D"im">>>the issue I reported as rejected on SourceForge. = =A0Can we reopen it to<br> >>reflect the conversation on this email thread? =A0I'd like it i= f we could<br> >>work on implementing your suggestion: "One thing I can think o= f that<br> >>would help with this example is discarding elements for which only = an end<br> >>tag is found, rather than generating a corresponding start tag.&quo= t;<br> ><br> >Ben,<br> ><br> >the bug report is open and I have a possible fix, I can send you the wi= n<br> >binary or you can try the modification below yourself if you want to<br= > >experiment with the patched version on another platform.<br> ><br> >Charlie,<br> ><br> >it's been a while since I touched the tidy source code (looked pret= ty<br> >unfamiliar :-)), the fix appears to resolve the specific issue and not<= br> >cause harm with a number of table related test cases I tried, would<br> >appreciate if you could look over this though and let me know if you ag= ree:<br> ><br> >RCS file: /cvsroot/tidy/tidy/src/parser.c,v<br> >retrieving revision 1.187<br> >diff -r1.187 parser.c<br> >3471,3472c3471,3475<br> >< =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 TY_(UngetToken)( doc );<br> >< =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 node =3D TY_(InferredTag)(doc, Tid= yTag_TABLE);<br> >---<br> > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 /*<br> </div>> <<a href=3D"http://tidy.sf.net/issue/2855621" target=3D"_blan= k">http://tidy.sf.net/issue/2855621</a>><a href=3D"http://tidy.sf.net/is= sue/2855621" target=3D"_blank">http://tidy.sf.net/issue/2855621</a> */<br> <div class=3D"im">> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (node->ty= pe !=3D EndTag) {<br> > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 TY_(UngetToken)( doc );<b= r> > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 node =3D TY_(InferredTag)= (doc, TidyTag_TABLE);<br> > > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 }<br> ><br> >--<br> >Klaus Johannes Rusch<br> </div>><mailto:<a href=3D"mailto:[email protected]">KlausRusch@a= tmedia.net</a>><a href=3D"mailto:[email protected]">KlausRusch@atme= dia.net</a><br> <div class=3D"im">><a href=3D"http://www.atmedia.net/KlausRusch/" target= =3D"_blank">http://www.atmedia.net/KlausRusch/</a><br> <br> <br> </div><div><div></div><div class=3D"h5">-----------------------------------= -------------------------------------------<br> Come build with us! The BlackBerry(R) Developer Conference in SF, CA<br> is the only developer event you need to attend this year. Jumpstart your<br= > developing skills, take BlackBerry mobile applications to market and stay<b= r> ahead of the curve. Join us from November 9 - 12, 2009. Register now!<br> <a href=3D"http://p.sf.net/sfu/devconference" target=3D"_blank">http://p.sf= .net/sfu/devconference</a><br> _______________________________________________<br> Tidy-develop mailing list<br> <a href=3D"mailto:[email protected]">[email protected]= urceforge.net</a><br> <a href=3D"https://lists.sourceforge.net/lists/listinfo/tidy-develop" targe= t=3D"_blank">https://lists.sourceforge.net/lists/listinfo/tidy-develop</a><= br> </div></div></blockquote></div><br> --000e0cd2965ecedd370476e03598-- --===============2920751422622768392== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference --===============2920751422622768392== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Tidy-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/tidy-develop --===============2920751422622768392==--