Re: CookieJar.java bug?
"Aaron Lee" <[email protected]>
| Newsgroups | gmane.comp.web.httpunit.devel |
|---|---|
| Message-ID | <[email protected]> |
HttpUnit is not really misparsing an actual cookie because it has a funny rule (in CookieJar.java::findCookies (c)) which recombine those comma separated pieces. I can certainly believe that there are cookies out there that doesn't conform to the standard, maybe that's the reason why we also include comma as the delimiter? Another thing I notice is CookieJar.java::isCookieReservedWord should also include httponly http://msdn.microsoft.com/workshop/author/dhtml/httponly_cookies.asp. Try parsing Set-Cookie: USER=123; expires=Wednesday, 09-Nov-99 23:12:40 GMT; path=/; HttpOnly I also wonder in Cookie.jar we should change the way we compare domains. I sometimes see website who send out domain=.mysite.com and then domain= mysite.com (missing the front dot). This confuses HttpUnit ... -Aaron On 6/1/06, Russell Gold <[email protected]> wrote: > > > On May 31, 2006, at 1:08 PM, Aaron Lee wrote: > > > Hi, > > > > In CookieJar.java function getCookieTokens has a line that reads > > > > st.whitespaceChars(44,44); // comma > > > > which seems wrong because we should only use semicolon as a > > delimiter to separate. > > Including comma would make parsing date format wrong: > > > > e.g. expires=Mon, 31-May-1976 17:07:24 GMT > > > > Can you show an example where HttpUnit is misparsing an actual > cookie? The rules are nasty because the spec changed rather > dramatically in the early days of cookies. > > > _______________________________________________ > Httpunit-develop mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/httpunit-develop > _______________________________________________ Httpunit-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/httpunit-develop