Re: Requirement of a new ServletRunner constructor in HttpUnit 1.7

Dear Xiaofeng,

you wrote:
> 1) About the unit test. Because I can't find a single unit test file
> for ServletRunner, I don't know where can I add the unit test for
> ServletRunner(InputStream, File, String). If it is enough to use other
> unit tests for proving the correctness, I think the call by other
> constructors are enough. Any more suggesstions?
To find such tests I usually set a break point (in this 
case it would be in one of the constructors that you'd 
like to extend) and then run all tests from the 
HttpUnitSuite. When the debugger halts at the breakpoint 
you'll see which test(s) called the constructor.
> 2) About the servlettest enabled problem, I think it is a small
> change. I changed it to make all servlet tests pass, so I patch it at
> the same time.
That is o.k. - that part would be not much trouble or 
effort to add.
> 3) About Time format change. Hmm, you are right. Maybe you can remove
> my code about this from the patch, my change is dirty, I agreed.
It's just that James had send another solution many 
months ago and I took his.
> 4) About one more error I found. My environment is : Core2 Quad 6600 +
> Windows XP SP3 + JDK1.6. I only use console on testing this, not using
> Eclipse. Classpath? Hmm, I think I just follow what the pom.xml file
> indicated.
The environment is almost the same as the one I am 
mostly testing with. Every once in a while I also test 
on a Suse Linux machine and/or a Mac OS system.
> In general, the first item is what I need. Others are just problems I
> found and fixed simply. Thanks for your review!
I'm looking forward to your JUnit test code + the few 
lines you'd like to get changed. The smaller the patch 
the quicker will be my response. Otherwise it depends a 
bit on how much debugging and testing is involved (Dan's 
change of today took many hours sigh :-( ...)

Yours
  Wolfgang

BITPlan - smart solutions
Pater-Delp-Str. 1, D-47877 Willich Schiefbahn
Tel. +49 2154 811-480, Fax +49 2154 811-481
Web: http://www.bitplan.de
bitplan GmbH, Willich - HRB 6820 Krefeld, VAT-ID: 10258040548, 
Geschäftsführer: Wolfgang Fahl

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

_______________________________________________
Httpunit-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/httpunit-develop