Re: [interchange] Remove redundant var declaration
Peter <[email protected]>
| Newsgroups | gmane.comp.web.interchange.users |
|---|---|
| Message-ID | <[email protected]> |
On 23/06/17 06:23, David Christensen wrote:
> Remove redundant var declaration
>
> diff --git a/lib/Vend/Table/DBI.pm b/lib/Vend/Table/DBI.pm
> index d3bc98b..f86fb22 100644
> --- a/lib/Vend/Table/DBI.pm
> +++ b/lib/Vend/Table/DBI.pm
> @@ -626,7 +626,7 @@ sub create {
> $config->{NAME} = $columns;
>
> # Quote identifiers
> - my ($qtable, $qkey, $qnames);
> + my $qnames;
> if ($config->{QUOTE_IDENTIFIERS}) {
> $qtable = $db->quote_identifier($tablename);
> $qkey = $db->quote_identifier($key);
I'm pretty sure you can remove the following redundant re-assignment to
those two variables as well. It would have resulted from patching 20+
places in the code to support quoting identifiers and missing the fact
that I already set those closer to the top of the same sub.
Peter