Re: [interchange] Correct logic of DisplayErrors

David Christensen <[email protected]> Mon, 11 Sep 2017 16:50:57 -0500

Newsgroups	gmane.comp.web.interchange.users
Message-ID	<[email protected]>

> On Sep 11, 2017, at 12:27 PM, David Christensen <[email protected]> wrote:
> 
> Hi Mike,
> 
> From HEAD^ (i.e., before my patch), we have the following in lib/Vend/Util.pm:
> 
> 	$Vend::Errors .= $msg . "\n"
> 		if $Vend::Cfg->{DisplayErrors} || $Global::DisplayErrors;
> 
> So this should be changed to also be &&, yes?  I’m happy to revert and fix this call site instead, since it sounds like there is an established reason and it wasn’t an oversight as I’d assumed. :-)

Upon reviewing this, I’ve decided to leave things as-is; this instance occurs within `logError()` which I believe could be called in either a global context or a catalog-level context.  I’m not convinced that turning this into an && won’t break this when called in a global context.

If you think I’m wrong about being wrong here :-), please feel free to push a correction for this instance.  I did go ahead and push a reversion to the commit which changed this logic.

Best,

David
--
David Christensen
End Point Corporation
[email protected]
785-727-1171

_______________________________________________
interchange-users mailing list
[email protected]
http://www.icdevgroup.org/mailman/listinfo/interchange-users

signature.asc (application/pgp-signature, 801 B)