RE: SSL, MirrorFrames and Redirects...

On Fri, 28 Mar 2003, Laird, Brian wrote:

>
> After doing some research I have come up with a proposed bug fix to the
> dupReply method in MirrorFrame.  Sorry for the poor formatting (outlook
> sucks for this kind of stuff)
>
> Description of changes:
> - When making a fake URL the new code honors the original incoming
> protocol (i.e. http or https)
> - The uloc variable is now created using the original request URL.
> This is to handle relative redirects more appropriately.  (I would be
> happy to provide our examples to explain what I mean in better detail)
> - Only change the location if the backend server (server being mirrored=
)
> returns a fully qualified path back to it's self.
> - If the location doesn't start with what we are mirroring then leave i=
t
> alone and the let the browser deal with it.  We found this solves most
> our problems with redirects.

MirrorFrame was mainly designed with only http in mind, and the case of
https has been to ften forgotten in some extensions and clearly.
I'll do some more tests, and pur your page in the cvs tree.
Thanks!

>
> Notes / Comments:
> - I have not tested this with partial mirroring, but I think they will =
work just fine
> - I realize that these changes may not follow the HTTP spec, but they d=
o reflect what I think most back end servers may do.  I read the spec, an=
d wasn't really sure that there is a right or wrong way to do it.
> - Sorry, I changed some of the braces and comments to make it easier to=
 read
> - this has only been tested with jdk 1.4 but most if not all of our "re=
direct" issues have been resolved
> - my grammer may be bad, but what do you expect from a developer :-)
>
> Old Code:
>     	switch(reply.getStatus())
>         {
>     	  case HTTP.MOVED_PERMANENTLY:
>     	  case HTTP.TEMPORARY_REDIRECT:
>     	  case HTTP.FOUND:
>     	  case HTTP.SEE_OTHER:
>     	      // Have fun !
>     	      String location =3D rep.getLocation();
>     	      if ((mirrors !=3D null) && (location !=3D null))
>               {
>         		  try
>                   {
>         		      URL uloc =3D new URL(mirrors, location);
>         		      URL loc  =3D getURL(request);
>         		      URL fake;
>         		      if (isPartialMirroring()) {
>         			  fake =3D new URL("http"
>         					 , loc.getHost()
>         					 , loc.getPort()
>         					 , getURLPath()+uloc.getFile());
>         		      } else {
>         			  fake =3D new URL("http"
>         					 , loc.getHost()
>         					 , loc.getPort()
>         					 , uloc.getFile());
>         		      }
>         		      reply.setLocation(fake);
>         		  }
>                   catch (Exception ex)
>                   {}
>     		  return reply;
>     	      } // end of if
>     	} //end of switch
>
> New Code:
>  	switch(reply.getStatus())
>         {
>     	  case HTTP.MOVED_PERMANENTLY:
>     	  case HTTP.TEMPORARY_REDIRECT:
>     	  case HTTP.FOUND:
>     	  case HTTP.SEE_OTHER:
>     	      // Have fun !
>             String location =3D rep.getLocation();
>             if ((mirrors !=3D null) && (location !=3D null))
>             {
>                 try
>                 {
>                     URL uloc =3D new URL(request.getURL(), location);
>                     //URL test =3D new URL(request.getURL(), location);
>                     URL loc  =3D getURL(request);
>                     URL fake =3D null;
>                     if (isPartialMirroring())
>                     {
>                         fake =3D new URL(request.getURL().getProtocol()
>                                  , loc.getHost()
>                                  , loc.getPort()
>                                  , getURLPath()+uloc.getFile());
>                     }
>                     else if (location.startsWith(mirrors.toString()))
>                     {
>                         fake =3D new URL(request.getURL().getProtocol()
>                              , loc.getHost()
>                              , loc.getPort()
>                              , uloc.getFile());
>                     }
>                     if (fake !=3D null)
>                         reply.setLocation(fake);
>                 }
>                 catch (Exception e)
>                 {}
>             }
>     	} //end of switch
>     	return reply;
>     }
>
>
>
> >  -----Original Message-----
> > From: 	Laird, Brian
> > Sent:	Thursday, March 27, 2003 4:49 PM
> > To:	[email protected]
> > Subject:	SSL, MirrorFrames and Redirects...
> >
> > This is meant to be a question / clarification of what I thought a Mi=
rrorFrame would do.  I have a server setup using SSL, and when I connect =
to it (ex: https:\\testserver) is actually "mirroring" another server (ex=
: http:\\backendserver).  When the backend server issues either a 301 or =
302 with a full URL specified in the location header field from the backe=
nd server (ex: http:\\testserver\somedir\somefile.html), the MirrorFrame =
doesn't convert it to SSL as I would expect (i.e. I am expecting the Mirr=
orFrame to make the location field look like https:\\testserver\somedir\s=
omefile.html).  Should the MirrorFrame handle this conversion back to SSL=
 or is meant to be done by a custom filter?
> >
> > Thanks for the continued help,
> > Brian
>

--=20
Yves Lafon - W3C
"Baroula que barouleras, au ti=E9u toujou t'entourneras."