Re: Re: Wrapping enhancements
Jonas Fonseca <[email protected]>
| Newsgroups | gmane.comp.web.links |
|---|---|
| Message-ID | <[email protected]> |
Eric Wald <[email protected]> wrote Thu, Jan 26, 2006: > Jonas Fonseca wrote: > > I'd be happy to take them but it should probably > > be option (didn't look if you did that). > > Not much is really optional, but it shouldn't disturb anything either. > I have put in a compile-time option to disable extra-long-line wrapping, > but even that shouldn't be necessary; just toggle wrapping for the page > if it ever becomes an issue. It would be nice if you could add WIDE_TABLE_LINES to setup.h with a small comment describing what it does else noone will be able to find it. I lean towards towards defining it by default. Atleast if/when merging this back to 0.11. In 0.12 I don't really care. > > Anyway, why don't you post them updated or not for 0.11 or 0.12? > > Done. The combined and updated (for 0.11) version is online at > http://www.brainshell.org/patches/elinks-0.11-wrapping.diff Ok, hope to soon apply them. However I don't like that you enable wrapping by default in init_document_options(). This also affects plain text rendering. We should probably add an option to control it. Oh, and the diff -p option is very nice so poor reviewers don't have to look up stuff like function names. ;) -- Jonas Fonseca _______________________________________________ elinks-dev mailing list [email protected] http://linuxfromscratch.org/mailman/listinfo/elinks-dev