Re: Wrapping enhancements

Jonas Fonseca wrote:
> It would be nice if you could add WIDE_TABLE_LINES to setup.h with a
> small comment describing what it does else no one will be able to find
> it. I lean towards towards defining it by default. At least if/when
> merging this back to 0.11. In 0.12 I don't really care.

All right, I added an option to setup.h, even though I completely missed
the fact that it existed until you pointed it out.  In addition to
disabling the feature by default, the option gets rid of the remaining
magic number in my code.

> Ok, hope to soon apply them. However I don't like that you enable
> wrapping by default in init_document_options(). This also affects plain
> text rendering. We should probably add an option to control it.

This has also been fixed, though the fix could be considered worse than
the old behavior.  Basically, document_options->wrap now has opposite
meaning for text and html views; it should probably be renamed, to
prevent future misunderstandings.

> Oh, and the diff -p option is very nice so poor reviewers don't have to
> look up stuff like function names. ;)

Done, even though two of the important bits are outside of functions.

http://www.brainshell.org/patches/elinks-0.11-wrapping-3.diff

- Eric
_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev