Re: [patch 1/5] Define separate structs for events passed

On Fri, Aug 04, 2006 at 02:21:15AM +0300, Kalle Olavi Niemitalo wrote:
> Define separate structs for events passed via the interlink socket.
> 
> This way, struct term_event can be changed without any interprocess
> compatibility problems.

It looks messy, but I don't know whether there is a better approach.
I'll need to think about it more. Of course, Jonas is the boss.

[...]
> diff --git a/src/terminal/event.c b/src/terminal/event.c
> index 291d3ef..58c53d8 100644
> --- a/src/terminal/event.c
> +++ b/src/terminal/event.c
> @@ -199,17 +199,18 @@ ignore_mouse_event(struct terminal *term
>  #endif
>  
>  static int
> -handle_interlink_event(struct terminal *term, struct term_event *ev)
> +handle_interlink_event(struct terminal *term, struct interlink_event *ilev)
[...]

What if we introduced a separate routine to convert term_event
to interlink_event, so as to minimise change to handle_interlink_event?

[...]
> -		term_send_event(term, ev);
> +		set_wh_term_event(&tev, ilev->ev,
> +				  ilev->info.size.width, ilev->info.size.height);
> +		term_send_event(term, &tev);

Why don't you use set_init_term_event?

[...]
> !-------------------------------------------------------------flip-
[...]

Oops, duplicated the other patches.

-- 
Miciah Masters <[email protected]> / <[email protected]>
_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev