Re: Force protocol.http.compression = 1 again?

Jonas Fonseca <[email protected]> writes:

> Wouldn't it have been easier to just leave out the option completely?

Do you mean easier for Pasky, who made that commit?

>> Anyway, instead of putting the both versions of the whole string
>> inside #if, I'd like to revert this commit altogether.
>> With Witek's latest changes, compression is not so experimental
>> any more, I think.  Can you find any site where it still fails?
>
> I haven't tested it personally, but I think it is the right thing to do.

Unfortunately, I already found a bug.  Content-Encoding: deflate
did not work at all.

I fixed the bug in elinks-0.12 but I am concerned that the bug
lurked for almost ten days before I noticed anything wrong.
There may be others like that remaining.  So, I think we should
give the new code at least two more weeks of testing before we
apply the changes to elinks-0.11.  (Please do not delay 0.11.4.)
During this time, the protocol.http.compression option lets one
easily check whether problems at a server are caused by
compression or not.

So, I won't remove the option quite yet.  I will however change
the default to enable compression, and possibly alter the
description.

After the encoding changes have been tested enough, we might
perhaps wrap the option in #if CONFIG_DEBUG && (CONFIG_GZIP ||
CONFIG_BZIP2 || CONFIG_LZMA).

Witek, can you change text/cgi/chunked_deflate.py to omit the
zlib header?

_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHxbW4Hm9IGt60eMgRAh8PAKC0mQJkvFSu7sdYJB1zW1xelFXMoQCgtolO
VhB2VzLJJVkbiIAm3owqUnk=
=Jf//
-----END PGP SIGNATURE-----