Re: please don't git describe in 0.12

Jonas Fonseca <[email protected]> writes:

> It was added in v1.5.4-rc1-21-g30ffa60.

Kalle☭Astalo:~/src/MIRROR/git 2$ git remote update
[...]
 * [new tag]         v1.5.4.2   -> v1.5.4.2
 * [new tag]         v1.5.4.3   -> v1.5.4.3
Kalle☭Astalo:~/src/MIRROR/git 2$ git describe --contains v1.5.4-rc1-21-g30ffa60
undefined
Kalle☭Astalo:~/src/MIRROR/git 2$ git --no-pager grep "only consider tags matching" $(git tag)
Kalle☭Astalo:~/src/MIRROR/git 2$

So, that commit is not in any released version of Git.

> Anyway, good old grep can probably also be used to pick a good candidate
> if you can get git-describe to list several tags.

I don't know if that is possible.
Perhaps with --debug, but the format of that output might change.

So then, the options appear to be:
(a) Do not use git describe.  Instead show the full SHA-1.
(b) Make me suffer improper use of tags.
(c) Make me move the tags out of .git/refs/tags/ so git describe
    doesn't see them.  This might have undesirable side effects.
(d) $(shell git describe --match "elinks-*" || git describe).
    Then make me upgrade Git to a version that supports --match.
    I would prefer postponing this until such a version is released.
(e) $(shell git describe --match "elinks-*" || git rev-parse HEAD).
(f) Change Git to let .git/config exclude patterns from git describe.
    Then make me upgrade Git to that version and add the option.
    I would prefer postponing this until such a version is released.

The "next" branch in git.git supports git describe --match, so it
seems likely that Git 1.5.5 will too.  I propose we do (e) now
and perhaps (d) after the Git 1.5.5 release.

_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHx8m8Hm9IGt60eMgRArQ9AJ9RN0fh8L2ChZOfhkBHqjruHHhwIQCfVZF9
AuQXmjqYs6pVLOk5+7YOM1A=
=HieJ
-----END PGP SIGNATURE-----