Re: Big files upload

Kalle Olavi Niemitalo <[email protected]> Mon, 19 May 2008 08:36:36 +0300
Newsgroups gmane.comp.web.links
Message-ID <[email protected]>
Witold Filipczyk <[email protected]> writes:

> (b) is not acceptable.
> I chose /dev/urandom.

Okay but please add error handling and a check that fread() got
all the bytes it wanted.

E.g. on Windows, there will be neither /dev/urandom nor
/dev/prandom, and ELinks should detect this rather than proceed
with an uninitialized and perhaps not very random buffer.

I see though that encode_multipart() does not properly handle
errors from e.g. add_char_to_string() either.  Anyway, it's
better to keep the bug in one function than spread it around.

_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev
signature.asc (application/pgp-signature, 188 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIMRHkHm9IGt60eMgRAnVJAJ9Xors8YEe8wM8JFI+tATdYpsS9/ACgpLJD
9GKFEkzp9MqjVYERIKQ70oI=
=Ggh8
-----END PGP SIGNATURE-----