Re: Adding fribidi support to elinks

أحمد المحمودي <[email protected]> wrote Tue, Jun 24, 2008:
> Hello,

Hej,

>   I am trying to add fribidi support to elinks, I had a couple of 
>   questions:
> 
>   1. what should I do to the configure scripts to detect fribidi ? Is it 
>   correct (and sufficient) to add those lines to configure.in:
> 
> PKG_CHECK_MODULES(FRIBIDI,fribidi >= 0.10.4)
> AC_SUBST(FRIBIDI_LIBS)
> AC_SUBST(FRIBIDI_CFLAGS)

I tried it and got this error:

    checking for FRIBIDI... configure: error: Package requirements (fribidi >= 0.10.4) were not met:
    
    No package 'fribidi' found
    
    Consider adjusting the PKG_CONFIG_PATH environment variable if you
    installed software in a non-standard prefix.
    
    Alternatively, you may set the environment variables FRIBIDI_CFLAGS
    and FRIBIDI_LIBS to avoid the need to call pkg-config.
    See the pkg-config man page for more details.

You need to find a way to gracefully handle the case that fribidi is not
installed.

>   2. In src/intl/charsets.h there is
> 
> typedef uint32_t unicode_val_T;
> 
>   I was  thinking to replace uint32_t with FriBidiChar (data type that 
>   fribidi uses), any problem with that ?

What are the guarantees of sizeof(FriBidiChar)? As long as it is wrapped
in some #ifdef CONFIG_FRIBIDI or similar construct I don't see why not.

-- 
Jonas Fonseca
_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev