Re: [PATCH] fix mangled indentation in configure --help

Kamil Dudka <[email protected]> writes:

> I've searched the proper solution last hour on the web. But it seems there is 
> no proper solution while using AC_HELP_STRING - consider this thread 
> http://www.mail-archive.com/[email protected]/msg08893.html
>
> So I've fixed the preexisting options with double quoting [[...]] - patch #1. 
> And I am also sending modified patch for NSS (patch #2), which shows [=DIR] - 
> here were used four more pairs of square brackets.

The release announcement of Autoconf 2.62 mentions:

 ** AS_HELP_STRING no longer underquotes its first argument; it also handles
 ~   the case where the first argument contains single-quoted commas.
 ~   For example, "AS_HELP_STRING([-a, [--arg[=foo]]], [bar])" produces:
 ~     "  -a, --arg[=foo]         bar"
 ~   Additionally, the macro now takes two additional arguments,
 ~   indent-column and wrap-column; these should not normally be needed,
 ~   but can be used to fine-tune how the output text is wrapped.

ELinks should be kept compatible with Autoconf 2.59, but if you
add four pairs of square brackets for that, I think Autoconf 2.62
will then include too many of them in the --help output.  So the
right solution seems to be to avoid AC_HELP_STRING and instead
align the strings by hand.  Alternatively, one could define
EL_HELP_STRING, but that would probably require more effort than
it'd save.

The alignment and brackets are minor details.  If you feel they
are costing too much time, I think it'd be enough to have the
same level of correctness as in the preexisting options.
I do not want the four pairs of square brackets though.

> +	if test -z "$with_nss_compat_ossl" -o "$with_nss_compat_ossl" = yes; then

The Autoconf manual advises against using the -a and -o operators
of test, because of variations in precedence.  Instead:

+	if test -z "$with_nss_compat_ossl" || test "$with_nss_compat_ossl" = yes; then

_______________________________________________
elinks-dev mailing list
[email protected]
http://linuxfromscratch.org/mailman/listinfo/elinks-dev

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIxuWAHm9IGt60eMgRAgRcAJ0f4N4Cz+gZtQaEuJLjeQq3XzcGCQCg0zBP
pO2lCGv4ELGmMm0AFnTJmPk=
=cPLX
-----END PGP SIGNATURE-----