Re: [PATCH] rewrite: add default "ddg" dumb/smart prefixes for DuckDuckGo

On Wednesday 19 September 2012 22:02:59 Kalle Olavi Niemitalo wrote:
> Kamil Dudka <[email protected]> writes:
> > +	INIT_OPT_SMART_PREFIX("ddg", "https://duckduckgo.com/?q=%s&t=elinks"),
> 
> ELinks can be built without SSL/TLS support, in which case it
> will pop up an error message when asked to open an https URL.
> This may be why all the other prefixes use http rather than
> https.  If you want to use https whenever possible, you can do
> this:
> 
> #ifdef CONFIG_SSL
> 	INIT_OPT_SMART_PREFIX("ddg", "https://duckduckgo.com/?q=%s&t=elinks"),
> #else
> 	INIT_OPT_SMART_PREFIX("ddg", "http://duckduckgo.com/?q=%s&t=elinks"),
> #endif
> 
> However, there is a risk that the http variant might get saved to
> ~/.elinks/elinks.conf, in which case ELinks will keep using that
> even if the user later installs an SSL/TLS-capable ELinks binary.
> Such saving happens if the user edits the rewriting rule, or if
> the user sets config.saving_style = 1 or 2.  I don't know whether
> this risk is so bad you'd prefer using https unconditionally.

Prakash, is it fine to use the non-SSL URLs (starting with http://)
for elinks?  They appear working to me...

Kamil